RTCCertificate serialization - persistent storage in IndexedDB.

RTCCertificate serialization - persistent storage in IndexedDB.

This is part of larger work that will allow persistent storage of
RTCCertificate in IndexedDB. The big picture can be seen here:
https://codereview.chromium.org/1949033002/

This CL implements part 2 and 3c:

2. RTCCertificate serialization (structured clone algorithm)
   a) ScriptValueSerializerForModules and friends are updated with write and
      read functions for RTCCertificate (impl using 1.).

3. Unittests making sure RTCCertificate can be saved and loaded from IndexedDB
   c) WebRtcBrowserTest tests added which clone certificates and sets up calls
      using the clones.

This is the final piece of the puzzle, pt 1 and 3a-b have already landed.
Landing this turns the feature on.

BUG=581354
Committed: https://crrev.com/f8730debe7de67ffc97aed74a5cd7f0cd799cb60
Cr-Commit-Position: refs/heads/master@{#392893}

[hbos_chromium, 2016-05-10 13:46:41]

hbos@chromium.org changed reviewers:
+ haraken@chromium.org, phoglund@chromium.org, tasak@google.com

[hbos_chromium, 2016-05-10 13:46:42]

Please take a look,
tasak for ScriptValueSerializerForModules and friends,
haraken for bindings owner,
phoglund for webrtc_browsertest.

[phoglund_chromium, 2016-05-10 15:54:16]

lgtm for browser test

[haraken, 2016-05-11 00:43:58]

LGTM

https://codereview.chromium.org/1959333002/diff/1/third_party/WebKit/Source/b...
File
third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp
(right):

https://codereview.chromium.org/1959333002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp:111:
return 0;

return nullptr;

https://codereview.chromium.org/1959333002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp:331:
return 0;

return nullptr;

[hbos_chromium, 2016-05-11 08:13:38]

Cool, landing with enough LGTMs and Intent to Ship also LGTM'd
(https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/duyso0oe6jM).

https://codereview.chromium.org/1959333002/diff/1/third_party/WebKit/Source/b...
File
third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp
(right):

https://codereview.chromium.org/1959333002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp:111:
return 0;
On 2016/05/11 00:43:58, haraken wrote:
> 
> return nullptr;

Done.

https://codereview.chromium.org/1959333002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp:331:
return 0;
On 2016/05/11 00:43:58, haraken wrote:
> 
> return nullptr;

Done.

[hbos_chromium, 2016-05-11 08:13:59]

The CQ bit was checked by hbos@chromium.org

[hbos_chromium, 2016-05-11 08:14:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, phoglund@chromium.org
Link to the patchset: https://codereview.chromium.org/1959333002/#ps20001
(title: "return nullptr;")

[commit-bot: I haz the power, 2016-05-11 08:14:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1959333002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1959333002/20001

[hbos_chromium, 2016-05-11 08:57:39]

Description was changed from

==========
RTCCertificate serialization - persistent storage in IndexedDB.

This is part of larger work that will allow persistent storage of
RTCCertificate in IndexedDB. The big picture can be seen here:
https://codereview.chromium.org/1949033002/

This CL implements part 2 and 3c:

2. RTCCertificate serialization (structured clone algorithm)
   a) ScriptValueSerializerForModules and friends are updated with write and
      read functions for RTCCertificate (impl using 1.).

3. Unittests making sure RTCCertificate can be saved and loaded from IndexedDB
   c) WebRtcBrowserTest tests added which clone certificates and sets up calls
      using the clones.

This is the final piece of the puzzle, pt 1 and 3a-b have already landed.
Landing this turns the feature on.

BUG=581384
==========

to

==========
RTCCertificate serialization - persistent storage in IndexedDB.

This is part of larger work that will allow persistent storage of
RTCCertificate in IndexedDB. The big picture can be seen here:
https://codereview.chromium.org/1949033002/

This CL implements part 2 and 3c:

2. RTCCertificate serialization (structured clone algorithm)
   a) ScriptValueSerializerForModules and friends are updated with write and
      read functions for RTCCertificate (impl using 1.).

3. Unittests making sure RTCCertificate can be saved and loaded from IndexedDB
   c) WebRtcBrowserTest tests added which clone certificates and sets up calls
      using the clones.

This is the final piece of the puzzle, pt 1 and 3a-b have already landed.
Landing this turns the feature on.

BUG=581354
==========

[commit-bot: I haz the power, 2016-05-11 10:21:03]

Description was changed from

==========
RTCCertificate serialization - persistent storage in IndexedDB.

This is part of larger work that will allow persistent storage of
RTCCertificate in IndexedDB. The big picture can be seen here:
https://codereview.chromium.org/1949033002/

This CL implements part 2 and 3c:

2. RTCCertificate serialization (structured clone algorithm)
   a) ScriptValueSerializerForModules and friends are updated with write and
      read functions for RTCCertificate (impl using 1.).

3. Unittests making sure RTCCertificate can be saved and loaded from IndexedDB
   c) WebRtcBrowserTest tests added which clone certificates and sets up calls
      using the clones.

This is the final piece of the puzzle, pt 1 and 3a-b have already landed.
Landing this turns the feature on.

BUG=581354
==========

to

==========
RTCCertificate serialization - persistent storage in IndexedDB.

This is part of larger work that will allow persistent storage of
RTCCertificate in IndexedDB. The big picture can be seen here:
https://codereview.chromium.org/1949033002/

This CL implements part 2 and 3c:

2. RTCCertificate serialization (structured clone algorithm)
   a) ScriptValueSerializerForModules and friends are updated with write and
      read functions for RTCCertificate (impl using 1.).

3. Unittests making sure RTCCertificate can be saved and loaded from IndexedDB
   c) WebRtcBrowserTest tests added which clone certificates and sets up calls
      using the clones.

This is the final piece of the puzzle, pt 1 and 3a-b have already landed.
Landing this turns the feature on.

BUG=581354
==========

[commit-bot: I haz the power, 2016-05-11 10:21:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-11 10:22:34]

Description was changed from

==========
RTCCertificate serialization - persistent storage in IndexedDB.

This is part of larger work that will allow persistent storage of
RTCCertificate in IndexedDB. The big picture can be seen here:
https://codereview.chromium.org/1949033002/

This CL implements part 2 and 3c:

2. RTCCertificate serialization (structured clone algorithm)
   a) ScriptValueSerializerForModules and friends are updated with write and
      read functions for RTCCertificate (impl using 1.).

3. Unittests making sure RTCCertificate can be saved and loaded from IndexedDB
   c) WebRtcBrowserTest tests added which clone certificates and sets up calls
      using the clones.

This is the final piece of the puzzle, pt 1 and 3a-b have already landed.
Landing this turns the feature on.

BUG=581354
==========

to

==========
RTCCertificate serialization - persistent storage in IndexedDB.

This is part of larger work that will allow persistent storage of
RTCCertificate in IndexedDB. The big picture can be seen here:
https://codereview.chromium.org/1949033002/

This CL implements part 2 and 3c:

2. RTCCertificate serialization (structured clone algorithm)
   a) ScriptValueSerializerForModules and friends are updated with write and
      read functions for RTCCertificate (impl using 1.).

3. Unittests making sure RTCCertificate can be saved and loaded from IndexedDB
   c) WebRtcBrowserTest tests added which clone certificates and sets up calls
      using the clones.

This is the final piece of the puzzle, pt 1 and 3a-b have already landed.
Landing this turns the feature on.

BUG=581354

Committed: https://crrev.com/f8730debe7de67ffc97aed74a5cd7f0cd799cb60
Cr-Commit-Position: refs/heads/master@{#392893}
==========

[commit-bot: I haz the power, 2016-05-11 10:22:35]

Patchset 2 (id:??) landed as
https://crrev.com/f8730debe7de67ffc97aed74a5cd7f0cd799cb60
Cr-Commit-Position: refs/heads/master@{#392893}