Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: pkg/mdv/lib/src/template_iterator.dart

Issue 19593006: [mdv] Implement two-way binding to HTMLTextArea.value (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/mdv/lib/src/template_iterator.dart
diff --git a/pkg/mdv/lib/src/bindings.dart b/pkg/mdv/lib/src/template_iterator.dart
similarity index 86%
rename from pkg/mdv/lib/src/bindings.dart
rename to pkg/mdv/lib/src/template_iterator.dart
index 1605a1ee246dbc5922b74b5d52506d8949b1ea29..67bc1235c647c3769f0af4c5da7891f67fbd6cb5 100644
--- a/pkg/mdv/lib/src/bindings.dart
+++ b/pkg/mdv/lib/src/template_iterator.dart
@@ -8,65 +8,6 @@ part of mdv;
// https://github.com/polymer-project/mdv
// The code mostly comes from src/template_element.js
-typedef void _ChangeHandler(value);
-
-abstract class _InputBinding {
- // InputElement or SelectElement
- final element;
- PathObserver binding;
- StreamSubscription _pathSub;
- StreamSubscription _eventSub;
-
- _InputBinding(this.element, model, String path) {
- binding = new PathObserver(model, path);
- _pathSub = binding.bindSync(valueChanged);
- _eventSub = _getStreamForInputType(element).listen(updateBinding);
- }
-
- void valueChanged(newValue);
-
- void updateBinding(e);
-
- void unbind() {
- binding = null;
- _pathSub.cancel();
- _eventSub.cancel();
- }
-
- static EventStreamProvider<Event> _checkboxEventType = () {
- // Attempt to feature-detect which event (change or click) is fired first
- // for checkboxes.
- var div = new DivElement();
- var checkbox = div.append(new InputElement());
- checkbox.type = 'checkbox';
- var fired = [];
- checkbox.onClick.listen((e) {
- fired.add(Element.clickEvent);
- });
- checkbox.onChange.listen((e) {
- fired.add(Element.changeEvent);
- });
- checkbox.dispatchEvent(new MouseEvent('click', view: window));
- // WebKit/Blink don't fire the change event if the element is outside the
- // document, so assume 'change' for that case.
- return fired.length == 1 ? Element.changeEvent : fired.first;
- }();
-
- static Stream<Event> _getStreamForInputType(element) {
- switch (element.type) {
- case 'checkbox':
- return _checkboxEventType.forTarget(element);
- case 'radio':
- case 'select-multiple':
- case 'select-one':
- return element.onChange;
- default:
- return element.onInput;
- }
- }
-}
-
-
// TODO(jmesserly): not sure what kind of boolean conversion rules to
// apply for template data-binding. HTML attributes are true if they're
// present. However Dart only treats "true" as true. Since this is HTML we'll

Powered by Google App Engine
This is Rietveld 408576698