Fixing compiler_version for Fedora.

Fixing compiler_version for Fedora.

BUG=353433
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257716

[mithro-old, 2014-03-18 05:14:12]

Hello,

The change to compiler_version to get binutils version
(https://codereview.chromium.org/197013010/) fails on Fedora as they modify the
version string. See https://code.google.com/p/chromium/issues/detail?id=353433
for more information.

This CL should fix the issue. Ideally we should have some type of tests for this
file in the future.

Tim

[Nico, 2014-03-18 10:02:56]

lgtm

"lol, linux"

[mithro-old, 2014-03-18 10:14:56]

The CQ bit was checked by mithro@mithis.com

[commit-bot: I haz the power, 2014-03-18 10:15:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/195923004/1

[mithro-old, 2014-03-18 10:15:04]

The CQ bit was unchecked by mithro@mithis.com

[mithro-old, 2014-03-18 10:17:55]

On 2014/03/18 10:15:04, mithro wrote:
> The CQ bit was unchecked by mailto:mithro@mithis.com

I wait to commit till the reporter confirms it fixes their issue.

[Adam Goode, 2014-03-18 13:58:50]

On 2014/03/18 10:17:55, mithro wrote:
> On 2014/03/18 10:15:04, mithro wrote:
> > The CQ bit was unchecked by mailto:mithro@mithis.com
> 
> I wait to commit till the reporter confirms it fixes their issue.

I have verified this patch works on Fedora 20.

$ python build/compiler_version.py 
48
$ python build/compiler_version.py compiler
48
$ python build/compiler_version.py assembler
223
$ python build/compiler_version.py linker
223

[mithro-old, 2014-03-18 14:02:59]

On 2014/03/18 13:58:50, Adam Goode wrote:
> On 2014/03/18 10:17:55, mithro wrote:
> > On 2014/03/18 10:15:04, mithro wrote:
> > > The CQ bit was unchecked by mailto:mithro@mithis.com
> > 
> > I wait to commit till the reporter confirms it fixes their issue.
> 
> I have verified this patch works on Fedora 20.
> 
> $ python build/compiler_version.py 
> 48
> $ python build/compiler_version.py compiler
> 48
> $ python build/compiler_version.py assembler
> 223
> $ python build/compiler_version.py linker
> 223

Great! Sending to the commit queue.

[mithro-old, 2014-03-18 14:03:03]

The CQ bit was checked by mithro@mithis.com

[commit-bot: I haz the power, 2014-03-18 14:03:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/195923004/1

[commit-bot: I haz the power, 2014-03-18 18:44:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-18 18:45:00]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[Lei Zhang, 2014-03-18 19:02:26]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-03-18 19:15:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/195923004/1

[commit-bot: I haz the power, 2014-03-18 19:29:31]

Change committed as 257716