Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: sdk/lib/_internal/pub/test/validator/dependency_test.dart

Issue 19592015: Get rid of hokey dependencyMapList stuff. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/test/update/hosted/update_removed_constraints_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/test/validator/dependency_test.dart
diff --git a/sdk/lib/_internal/pub/test/validator/dependency_test.dart b/sdk/lib/_internal/pub/test/validator/dependency_test.dart
index 87d926a59666901a607296ffa12f4eabbd490bad..57b380f6d0681bd051d980bc8269b865a7e4c322 100644
--- a/sdk/lib/_internal/pub/test/validator/dependency_test.dart
+++ b/sdk/lib/_internal/pub/test/validator/dependency_test.dart
@@ -50,7 +50,7 @@ setUpDependency(Map dep, {List<String> hostedVersions}) {
}));
d.dir(appPath, [
- d.libPubspec("test_pkg", "1.0.0", deps: [dep])
+ d.libPubspec("test_pkg", "1.0.0", deps: {"foo": dep})
]).create();
}
@@ -155,9 +155,9 @@ main() {
group('and it should not suggest a version', () {
integration("if there's no lockfile", () {
d.dir(appPath, [
- d.libPubspec("test_pkg", "1.0.0", deps: [
- {'hosted': 'foo'}
- ])
+ d.libPubspec("test_pkg", "1.0.0", deps: {
+ "foo": "any"
+ })
]).create();
expect(schedulePackageValidation(dependency), completion(
@@ -167,9 +167,9 @@ main() {
integration("if the lockfile doesn't have an entry for the "
"dependency", () {
d.dir(appPath, [
- d.libPubspec("test_pkg", "1.0.0", deps: [
- {'hosted': 'foo'}
- ]),
+ d.libPubspec("test_pkg", "1.0.0", deps: {
+ "foo": "any"
+ }),
d.file("pubspec.lock", json.stringify({
'packages': {
'bar': {
@@ -193,9 +193,9 @@ main() {
integration('and it should suggest a constraint based on the locked '
'version', () {
d.dir(appPath, [
- d.libPubspec("test_pkg", "1.0.0", deps: [
- {'hosted': 'foo'}
- ]),
+ d.libPubspec("test_pkg", "1.0.0", deps: {
+ "foo": "any"
+ }),
d.file("pubspec.lock", json.stringify({
'packages': {
'foo': {
@@ -216,9 +216,9 @@ main() {
integration('and it should suggest a concrete constraint if the locked '
'version is pre-1.0.0', () {
d.dir(appPath, [
- d.libPubspec("test_pkg", "1.0.0", deps: [
- {'hosted': 'foo'}
- ]),
+ d.libPubspec("test_pkg", "1.0.0", deps: {
+ "foo": "any"
+ }),
d.file("pubspec.lock", json.stringify({
'packages': {
'foo': {
@@ -240,9 +240,9 @@ main() {
integration('has a hosted dependency on itself', () {
d.dir(appPath, [
- d.libPubspec("test_pkg", "1.0.0", deps: [
- {'hosted': {'name': 'test_pkg', 'version': '>=1.0.0'}}
- ])
+ d.libPubspec("test_pkg", "1.0.0", deps: {
+ "test_pkg": ">=1.0.0"
+ })
]).create();
expectValidationWarning(dependency);
« no previous file with comments | « sdk/lib/_internal/pub/test/update/hosted/update_removed_constraints_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698