Issue 19592008: Revert 212337 "[android] Ignore extra files on the client when c..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19592008: Revert 212337 "[android] Ignore extra files on the client when c..." (Closed)

Created:
7 years, 5 months ago by Philippe

Modified:
7 years, 5 months ago

Reviewers:
craigdh, pliard

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 212337 "[android] Ignore extra files on the client when c..." The following assertion seems to fail: assert all(len(s) == 2 for s in split_lines), 'Invalid md5sum output' > [android] Ignore extra files on the client when comparing md5sum output. > > BUG=None > TEST=None > NOTRY=True > > Review URL: https://chromiumcodereview.appspot.com/19675006 TBR=craigdh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212355

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -30 lines)			Patch
	M	trunk/src/build/android/pylib/android_commands.py	View		2 chunks	+7 lines, -30 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pliard

7 years, 5 months ago (2013-07-18 15:01:14 UTC) #3

Sorry Craig for the revert :/


On Thu, Jul 18, 2013 at 4:58 PM, <pliard@chromium.org> wrote:

> Committed patchset #1 manually as r212355.
>
>
https://codereview.chromium.**org/19592008/<https://codereview.chromium.org/1...
>

Expand Messages | Collapse Messages