Fix depot_tools presubmit's local_rietveld script.

Fix depot_tools presubmit's local_rietveld script.

This was breaking presubmit because the linked gae_ts_mon subdir was absent.

R=andybons@chromium.org, dsansome@chromium.org, dnj@chromium.org
BUG=608490
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300511

[iannucci, 2016-05-09 20:25:47]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 20:25:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1959193002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1959193002/1

[commit-bot: I haz the power, 2016-05-09 20:30:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 20:30:21]

Dry run: Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[iannucci, 2016-05-09 20:31:43]

blar these hacks are insufficient. I'll add some more.

[iannucci, 2016-05-09 21:26:11]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 21:26:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1959193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1959193002/20001

[commit-bot: I haz the power, 2016-05-09 21:31:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 21:31:11]

Dry run: Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[iannucci, 2016-05-09 22:54:56]

Description was changed from

==========
Fix depot_tools presubmit's local_rietveld script.

This was breaking presubmit because the linked gae_ts_mon subdir was absent.

R=andybons@chromium.org, davesansom@chromium.org, dnj@chromium.org
BUG=608490
==========

to

==========
Fix depot_tools presubmit's local_rietveld script.

This was breaking presubmit because the linked gae_ts_mon subdir was absent.

R=andybons@chromium.org, davesansome@chromium.org, dnj@chromium.org
BUG=608490
==========

[iannucci, 2016-05-09 22:54:56]

iannucci@chromium.org changed reviewers:
+ davesansome@chromium.org
- davesansom@chromium.org

[iannucci, 2016-05-09 22:55:31]

Description was changed from

==========
Fix depot_tools presubmit's local_rietveld script.

This was breaking presubmit because the linked gae_ts_mon subdir was absent.

R=andybons@chromium.org, davesansome@chromium.org, dnj@chromium.org
BUG=608490
==========

to

==========
Fix depot_tools presubmit's local_rietveld script.

This was breaking presubmit because the linked gae_ts_mon subdir was absent.

R=andybons@chromium.org, dsansome@chromium.org, dnj@chromium.org
BUG=608490
==========

[iannucci, 2016-05-09 22:55:31]

iannucci@chromium.org changed reviewers:
+ dsansome@chromium.org
- davesansome@chromium.org

[iannucci, 2016-05-09 22:56:02]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 22:56:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1959193002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1959193002/40001

[commit-bot: I haz the power, 2016-05-09 23:01:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 23:01:22]

Dry run: This issue passed the CQ dry run.

[dnj (Google), 2016-05-09 23:13:09]

dnj@google.com changed reviewers:
+ dnj@google.com

[dnj (Google), 2016-05-09 23:13:10]

lgtm w/ comment

https://codereview.chromium.org/1959193002/diff/40001/.gitignore
File .gitignore (right):

https://codereview.chromium.org/1959193002/diff/40001/.gitignore#newcode46
.gitignore:46: /testing_support/_infra
I hate to say it, but I think we should leave the old gitignore entries in there
just in case someone has run this script once but won't run it again. That way
we won't block other peoples' depot_tools on some random directories they didn't
know existed being cleaned up.

[iannucci, 2016-05-09 23:14:14]

On 2016/05/09 23:13:10, dnj (Google) wrote:
> lgtm w/ comment
> 
> https://codereview.chromium.org/1959193002/diff/40001/.gitignore
> File .gitignore (right):
> 
> https://codereview.chromium.org/1959193002/diff/40001/.gitignore#newcode46
> .gitignore:46: /testing_support/_infra
> I hate to say it, but I think we should leave the old gitignore entries in
there
> just in case someone has run this script once but won't run it again. That way
> we won't block other peoples' depot_tools on some random directories they
didn't
> know existed being cleaned up.

done

[agable, 2016-05-09 23:20:31]

agable@chromium.org changed reviewers:
+ agable@chromium.org
- dnj@google.com

[agable, 2016-05-09 23:20:31]

This basically makes sense, and that makes me sad. No specific comments, just
tears. LGTM.

[iannucci, 2016-05-09 23:22:11]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2016-05-09 23:22:12]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@google.com
Link to the patchset: https://chromiumcodereview.appspot.com/1959193002/#ps60001
(title: "gitignore")

[commit-bot: I haz the power, 2016-05-09 23:22:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1959193002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1959193002/60001

[commit-bot: I haz the power, 2016-05-09 23:26:38]

Description was changed from

==========
Fix depot_tools presubmit's local_rietveld script.

This was breaking presubmit because the linked gae_ts_mon subdir was absent.

R=andybons@chromium.org, dsansome@chromium.org, dnj@chromium.org
BUG=608490
==========

to

==========
Fix depot_tools presubmit's local_rietveld script.

This was breaking presubmit because the linked gae_ts_mon subdir was absent.

R=andybons@chromium.org, dsansome@chromium.org, dnj@chromium.org
BUG=608490

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300511
==========

[commit-bot: I haz the power, 2016-05-09 23:26:39]

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300511

[dsansome, 2016-05-10 07:37:45]

I didn't even know this was a thing - thanks for fixing it!

https://codereview.chromium.org/1959193002/diff/60001/fetch.py
File fetch.py (right):

https://codereview.chromium.org/1959193002/diff/60001/fetch.py#newcode260
fetch.py:260: while len(argv) >= 2:
Parsing arguments manually in Python... what year is it?

https://codereview.chromium.org/1959193002/diff/60001/testing_support/local_r...
File testing_support/local_rietveld.py (right):

https://codereview.chromium.org/1959193002/diff/60001/testing_support/local_r...
testing_support/local_rietveld.py:29:
DEPOT_TOOLS=os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
dirname of dirname?

Also nit: probably put spaces around the =