Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1959183003: Add GetSurfaceManager to ui::ContextFactory. (Closed)

Created:
4 years, 7 months ago by jbauman
Modified:
4 years, 7 months ago
Reviewers:
sky, piman
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GetSurfaceManager to ui::ContextFactory. This allows anything that can get a ui compositor to make a surface that can be used with it. BUG=610086 Committed: https://crrev.com/42f96a8aea7460b92a8d9b1e9faddf6fe7d2bcd4 Cr-Commit-Position: refs/heads/master@{#393387}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M ash/mus/stub_context_factory.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/stub_context_factory.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ui/compositor/compositor.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/mus/surface_context_factory.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/surface_context_factory.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
jbauman
4 years, 7 months ago (2016-05-11 22:53:58 UTC) #3
piman
lgtm
4 years, 7 months ago (2016-05-11 23:07:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959183003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959183003/20001
4 years, 7 months ago (2016-05-11 23:29:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/181693)
4 years, 7 months ago (2016-05-11 23:37:14 UTC) #8
jbauman
+sky@ for ash/ and ui/views OWNERS
4 years, 7 months ago (2016-05-12 00:24:06 UTC) #10
sky
LGTM - as long as returning null for mus doesn't break anything.
4 years, 7 months ago (2016-05-12 16:11:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959183003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959183003/20001
4 years, 7 months ago (2016-05-12 22:32:55 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-12 23:08:09 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 23:09:54 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/42f96a8aea7460b92a8d9b1e9faddf6fe7d2bcd4
Cr-Commit-Position: refs/heads/master@{#393387}

Powered by Google App Engine
This is Rietveld 408576698