Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1959183002: Multi-Process Find-in-Page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disabled tests on Android Release because of crbug.com/615291. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 9dd58dfcc0d67d08091408326d7ab2d8dca7d515..47927a9027de63e590e21d890c7f9b6b6532f19a 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -622,6 +622,14 @@ ScrollableArea* WebLocalFrameImpl::layoutViewportScrollableArea() const
return nullptr;
}
+bool WebLocalFrameImpl::isFocused() const
+{
+ if (!viewImpl() || !viewImpl()->page())
+ return false;
+
+ return this == WebFrame::fromFrame(viewImpl()->page()->focusController().focusedFrame());
+}
+
WebSize WebLocalFrameImpl::scrollOffset() const
{
if (ScrollableArea* scrollableArea = layoutViewportScrollableArea())
@@ -1542,11 +1550,8 @@ LocalFrame* WebLocalFrameImpl::createChildFrame(const FrameLoadRequest& request,
void WebLocalFrameImpl::didChangeContentsSize(const IntSize& size)
{
- // This is only possible on the main frame.
- if (m_textFinder && m_textFinder->totalMatchCount() > 0) {
- DCHECK(!parent());
+ if (m_textFinder && m_textFinder->totalMatchCount() > 0)
m_textFinder->increaseMarkerVersion();
- }
}
void WebLocalFrameImpl::createFrameView()
@@ -1614,12 +1619,7 @@ WebDataSourceImpl* WebLocalFrameImpl::provisionalDataSourceImpl() const
void WebLocalFrameImpl::setFindEndstateFocusAndSelection()
{
- WebLocalFrameImpl* mainFrameImpl = viewImpl()->mainFrameImpl();
-
- // Main frame should already have a textFinder at this point of time.
- DCHECK(mainFrameImpl->textFinder());
-
- if (this != mainFrameImpl->textFinder()->activeMatchFrame())
+ if (!m_textFinder || !m_textFinder->activeMatchFrame())
return;
if (Range* activeMatch = m_textFinder->activeMatch()) {
@@ -1962,16 +1962,34 @@ void WebLocalFrameImpl::didCallIsSearchProviderInstalled()
bool WebLocalFrameImpl::find(int identifier, const WebString& searchText, const WebFindOptions& options, bool wrapWithinFrame, WebRect* selectionRect, bool* activeNow)
{
- return ensureTextFinder().find(identifier, searchText, options, wrapWithinFrame, selectionRect, activeNow);
+ // Search for an active match only if this frame is focused or if this is a
+ // find next request.
+ if (isFocused() || options.findNext)
+ return ensureTextFinder().find(identifier, searchText, options, wrapWithinFrame, selectionRect, activeNow);
+
+ return false;
}
-void WebLocalFrameImpl::stopFinding(bool clearSelection)
+void WebLocalFrameImpl::stopFinding(StopFindAction action)
{
+ bool clearSelection = action == StopFindActionClearSelection;
+ if (clearSelection)
+ executeCommand(WebString::fromUTF8("Unselect"));
+
if (m_textFinder) {
if (!clearSelection)
setFindEndstateFocusAndSelection();
m_textFinder->stopFindingAndClearSelection();
}
+
+ if (action == StopFindActionActivateSelection && isFocused()) {
+ WebDocument doc = document();
+ if (!doc.isNull()) {
+ WebElement element = doc.focusedElement();
+ if (!element.isNull())
+ element.simulateClick();
+ }
+ }
}
void WebLocalFrameImpl::scopeStringMatches(int identifier, const WebString& searchText, const WebFindOptions& options, bool reset)
@@ -1987,8 +2005,6 @@ void WebLocalFrameImpl::cancelPendingScopingEffort()
void WebLocalFrameImpl::increaseMatchCount(int count, int identifier)
{
- // This function should only be called on the mainframe.
- DCHECK(!parent());
ensureTextFinder().increaseMatchCount(identifier, count);
}
@@ -2005,8 +2021,6 @@ void WebLocalFrameImpl::dispatchMessageEventWithOriginCheck(const WebSecurityOri
int WebLocalFrameImpl::findMatchMarkersVersion() const
{
- DCHECK(!parent());
-
if (m_textFinder)
return m_textFinder->findMatchMarkersVersion();
return 0;
@@ -2014,14 +2028,18 @@ int WebLocalFrameImpl::findMatchMarkersVersion() const
int WebLocalFrameImpl::selectNearestFindMatch(const WebFloatPoint& point, WebRect* selectionRect)
{
- DCHECK(!parent());
return ensureTextFinder().selectNearestFindMatch(point, selectionRect);
}
-WebFloatRect WebLocalFrameImpl::activeFindMatchRect()
+float WebLocalFrameImpl::distanceToNearestFindMatch(const WebFloatPoint& point)
{
- DCHECK(!parent());
+ float nearestDistance;
+ ensureTextFinder().nearestFindMatch(point, &nearestDistance);
+ return nearestDistance;
+}
+WebFloatRect WebLocalFrameImpl::activeFindMatchRect()
+{
if (m_textFinder)
return m_textFinder->activeFindMatchRect();
return WebFloatRect();
@@ -2029,7 +2047,6 @@ WebFloatRect WebLocalFrameImpl::activeFindMatchRect()
void WebLocalFrameImpl::findMatchRects(WebVector<WebFloatRect>& outputRects)
{
- DCHECK(!parent());
ensureTextFinder().findMatchRects(outputRects);
}
@@ -2098,4 +2115,9 @@ void WebLocalFrameImpl::forceSandboxFlags(WebSandboxFlags flags)
frame()->loader().forceSandboxFlags(static_cast<SandboxFlags>(flags));
}
+void WebLocalFrameImpl::clearActiveFindMatch()
+{
+ ensureTextFinder().clearActiveFindMatch();
+}
+
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.h ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698