Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 1959183002: Multi-Process Find-in-Page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments by nick@, and a bit of cleanup. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.h
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.h b/third_party/WebKit/Source/web/WebLocalFrameImpl.h
index 19b1f74c91f24810ca8cb008e1a5e5ee7b52fb19..c5229d7bd81ee6ee95cbdd2e350fc089b320c2a0 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.h
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.h
@@ -229,7 +229,7 @@ public:
bool find(
int identifier, const WebString& searchText, const WebFindOptions&,
bool wrapWithinFrame, WebRect* selectionRect, bool* activeNow = nullptr) override;
- void stopFinding(bool clearSelection) override;
+ void stopFinding(StopFindAction) override;
void scopeStringMatches(
int identifier, const WebString& searchText, const WebFindOptions&,
bool reset) override;
@@ -240,8 +240,10 @@ public:
WebFloatRect activeFindMatchRect() override;
void findMatchRects(WebVector<WebFloatRect>&) override;
int selectNearestFindMatch(const WebFloatPoint&, WebRect* selectionRect) override;
+ float distanceToNearestFindMatch(const WebFloatPoint&) override;
void setTickmarks(const WebVector<WebRect>&) override;
WebFrameWidget* frameWidget() const override;
+ void clearActiveFindMatch() override;
// WebFrameImplBase methods:
void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString& name, const AtomicString& uniqueName) override;
@@ -351,6 +353,9 @@ private:
WebPlugin* focusedPluginIfInputMethodSupported();
ScrollableArea* layoutViewportScrollableArea() const;
+ // Returns true if the frame is focused.
+ bool isFocused() const;
+
Member<FrameLoaderClientImpl> m_frameLoaderClientImpl;
// The embedder retains a reference to the WebCore LocalFrame while it is active in the DOM. This

Powered by Google App Engine
This is Rietveld 408576698