components/test_runner/test_runner_for_specific_view.cc - Issue 1959183002: Multi-Process Find-in-Page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/test_runner_for_specific_view.cc

Issue 1959183002: Multi-Process Find-in-Page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments by nick@, and a bit of cleanup. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/test_runner/test_runner_for_specific_view.cc

diff --git a/components/test_runner/test_runner_for_specific_view.cc b/components/test_runner/test_runner_for_specific_view.cc

index 75b8d0d0475439642e4ecaf5c7329df7e73ab5d7..90c12ca57aeedbfa85247feafe29e839fbf1c2f9 100644

--- a/components/test_runner/test_runner_for_specific_view.cc

+++ b/components/test_runner/test_runner_for_specific_view.cc

@@ -653,7 +653,7 @@ bool TestRunnerForSpecificView::FindString(

WebLocalFrame* frame = web_view()->mainFrame()->toWebLocalFrame();

const bool find_result = frame->find(0, WebString::fromUTF8(search_text),

find_options, wrap_around, 0);

- frame->stopFinding(false);

+ frame->stopFinding(WebLocalFrame::StopFindActionKeepSelection);

return find_result;

}