Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1959173002: Stop valgrind bot from crashing (Closed)

Created:
4 years, 7 months ago by scroggo_chromium
Modified:
4 years, 7 months ago
Reviewers:
scroggo, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Stop valgrind bot from crashing make_surface is returning nullptr, resulting in an invalid read. Add an error message with debugging information and skip this iteration. Also switch to cleaner for loop syntax. BUG=skia:5282 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1959173002 Committed: https://skia.googlesource.com/skia/+/e6cad6b370d781c0e8345b5be74b83c2c328074c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M gm/surface.cpp View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959173002/1
4 years, 7 months ago (2016-05-09 19:44:46 UTC) #3
scroggo_chromium
4 years, 7 months ago (2016-05-09 19:47:33 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-09 20:10:15 UTC) #7
egdaniel
lgtm
4 years, 7 months ago (2016-05-09 20:18:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959173002/1
4 years, 7 months ago (2016-05-09 20:20:07 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 20:21:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e6cad6b370d781c0e8345b5be74b83c2c328074c

Powered by Google App Engine
This is Rietveld 408576698