Implement CPU time for OS X and POSIX.

test/unittests/base/platform/time-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/base/platform/time.h"
 
 #if V8_OS_MACOSX
 #include <mach/mach_time.h>
 #endif
 #if V8_OS_POSIX
 #include <sys/time.h>
 #endif
 
 #if V8_OS_WIN
 #include "src/base/win32-headers.h"
 #endif
 
 #include "src/base/platform/elapsed-timer.h"
+#include "src/base/platform/platform.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace v8 {
 namespace base {
 
 TEST(TimeDelta, FromAndIn) {
   EXPECT_EQ(TimeDelta::FromDays(2), TimeDelta::FromHours(48));
   EXPECT_EQ(TimeDelta::FromHours(3), TimeDelta::FromMinutes(180));
   EXPECT_EQ(TimeDelta::FromMinutes(2), TimeDelta::FromSeconds(120));
   EXPECT_EQ(TimeDelta::FromSeconds(2), TimeDelta::FromMilliseconds(2000));
@@ skipping 146 matching lines @@
     TimeTicks highres_ticks = TimeTicks::HighResolutionNow();
     EXPECT_GE(normal_ticks, previous_normal_ticks);
     EXPECT_GE((normal_ticks - previous_normal_ticks).InMicroseconds(), 0);
     EXPECT_GE(highres_ticks, previous_highres_ticks);
     EXPECT_GE((highres_ticks - previous_highres_ticks).InMicroseconds(), 0);
     previous_normal_ticks = normal_ticks;
     previous_highres_ticks = highres_ticks;
   }
 }
 
+
+// Disable on windows until it is implemented.
+#if V8_OS_ANDROID || V8_OS_WIN

[fmeawad, 2016/05/09 23:24:56]

Why are you disabling the test on Android?

[lpy, 2016/05/09 23:51:15]

This test is ported from Chrome, and Chrome disables it on Android.

+#define MAYBE_ThreadNow DISABLED_ThreadNow
+#else
+#define MAYBE_ThreadNow ThreadNow
+#endif
+TEST(ThreadTicks, MAYBE_ThreadNow) {
+  if (ThreadTicks::IsSupported()) {

[fmeawad, 2016/05/09 23:24:56]

How about testing IsSupported itself?

[lpy, 2016/05/09 23:51:15]

Is it necessary? ThreadTicks::IsSupported doesn't do any calculation, just
returns true when some macros are defined and false otherwise.

[fmeawad, 2016/05/10 18:12:48]

It is very necessary, but I cannot think of a good testing strategy. The problem
with this test as it stands is that if IsSupported is buggy and always returns
false we also loose coverage for ::Now()

+    TimeTicks begin = TimeTicks::Now();
+    ThreadTicks begin_thread = ThreadTicks::Now();
+    // Make sure that ThreadNow value is non-zero.
+    EXPECT_GT(begin_thread, ThreadTicks());
+    // Sleep for 10 milliseconds to get the thread de-scheduled.
+    OS::Sleep(base::TimeDelta::FromMilliseconds(10));
+    ThreadTicks end_thread = ThreadTicks::Now();
+    TimeTicks end = TimeTicks::Now();
+    TimeDelta delta = end - begin;
+    TimeDelta delta_thread = end_thread - begin_thread;
+    // Make sure that some thread time have elapsed.
+    EXPECT_GT(delta_thread.InMicroseconds(), 0);
+    // But the thread time is at least 9ms less than clock time.
+    TimeDelta difference = delta - delta_thread;
+    EXPECT_GE(difference.InMicroseconds(), 9000);
+  }
+}
+
 }  // namespace base
 }  // namespace v8