Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1959103003: Revert of Test dismissing CVC prompt for PaymentRequest (Closed)

Created:
4 years, 7 months ago by iclelland
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Test dismissing CVC prompt for PaymentRequest (patchset #1 id:1 of https://codereview.chromium.org/1958873002/ ) Reason for revert: Breaks on Android GN tests with a StrictModeViolation that gets the death penalty :( C 912.834s Main ******************************************************************************** C 912.834s Main Detailed Logs C 912.834s Main ******************************************************************************** C 912.837s Main [FAIL] org.chromium.chrome.browser.payments.PaymentRequestNoShippingTest#testPayAndCancelDialog: C 912.837s Main android.os.StrictMode$StrictModeViolation: policy=2639 violation=2 C 912.837s Main at android.os.StrictMode.executeDeathPenalty(StrictMode.java:1377) C 912.837s Main at android.os.StrictMode.access$1300(StrictMode.java:116) C 912.837s Main at android.os.StrictMode$AndroidBlockGuardPolicy.handleViolation(StrictMode.java:1370) C 912.837s Main at android.os.StrictMode$AndroidBlockGuardPolicy$1.run(StrictMode.java:1252) C 912.837s Main at android.os.Handler.handleCallback(Handler.java:733) C 912.837s Main at android.os.Handler.dispatchMessage(Handler.java:95) C 912.837s Main at android.os.Looper.loop(Looper.java:136) C 912.837s Main at android.app.ActivityThread.main(ActivityThread.java:5017) C 912.837s Main at java.lang.reflect.Method.invokeNative(Native Method) C 912.837s Main at java.lang.reflect.Method.invoke(Method.java:515) C 912.837s Main at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779) C 912.837s Main at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595) C 912.837s Main at dalvik.system.NativeStart.main(Native Method) C 912.837s Main C 912.837s Main Search logcat for "StrictMode policy violation" for full stack. C 912.837s Main ******************************************************************************** The full build is at https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20GN/builds/34198 Original issue's description: > Test dismissing CVC prompt for PaymentRequest > > This is an integration test for PaymentRequest that performs the > following steps: > 1) Launch PaymentRequest UI. > 2) Click "Pay" in PaymentRequest UI. > 3) Click "Cancel" in CVC prompt. > 4) Click "OK" to dismiss the result dialog. > > BUG=608223 > > Committed: https://crrev.com/ae3e707b1e771518538a8f12de5cdf88e0aef865 > Cr-Commit-Position: refs/heads/master@{#392347} TBR=dfalcantara@chromium.org,rouslan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608223 Committed: https://crrev.com/ce49849aadf7c4378c99cc4da45b3ff7671cdde8 Cr-Commit-Position: refs/heads/master@{#392394}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 3 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
iclelland
Created Revert of Test dismissing CVC prompt for PaymentRequest
4 years, 7 months ago (2016-05-09 19:26:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959103003/1
4 years, 7 months ago (2016-05-09 19:27:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 19:27:58 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 19:29:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce49849aadf7c4378c99cc4da45b3ff7671cdde8
Cr-Commit-Position: refs/heads/master@{#392394}

Powered by Google App Engine
This is Rietveld 408576698