Issue 19591006: Deprecate v8::V8::Pause/ResumeProfiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19591006: Deprecate v8::V8::Pause/ResumeProfiler (Closed)

Created:
7 years, 5 months ago by yurys

Modified:
7 years, 5 months ago

Reviewers:
Yang, danno, loislo

CC:
v8-dev, alph

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Deprecate v8::V8::Pause/ResumeProfiler The methods were added to the public API in r1185 when Chrome DevTools were using the same output as produced for tick processor when --prof option is specified. I don't see any existing clients of these methods and since they add a noticeable complexity to the profiler code I'd like to remove them. BUG=None R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15828

Patch Set 1 #

Patch Set 2 : Updare #

Patch Set 3 : Update #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -51 lines)			Patch
M	include/v8.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/d8.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/d8.cc	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	src/debug-debugger.js	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	src/runtime.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	test/cctest/test-log.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2013/07/23 12:13:41, Yury Semikhatsky wrote:

lgtm.

Expand Messages | Collapse Messages