Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1959063004: Revert of Set argv[0] of the buildbot master process to the name of the master. (Closed)

Created:
4 years, 7 months ago by dnj (Google)
Modified:
4 years, 7 months ago
Reviewers:
dnj, friedman, dsansome, iannucci
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Set argv[0] of the buildbot master process to the name of the master. (patchset #2 id:20001 of https://codereview.chromium.org/1963583002/ ) Reason for revert: This causes all "chromium.infra" and "chromium.infra.cron" builds to fail because we are "sys.exit(2)" on non-Linux platforms. This can't be what you meant to do. Original issue's description: > Set argv[0] of the buildbot master process to the name of the master. > > BUG=609995 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300520 TBR=friedman@chromium.org,iannucci@chromium.org,dsansome@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=609995 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -39 lines) Patch
M scripts/master/master_utils.py View 3 chunks +0 lines, -39 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
dnj (Google)
Created Revert of Set argv[0] of the buildbot master process to the name of the ...
4 years, 7 months ago (2016-05-10 16:32:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959063004/1
4 years, 7 months ago (2016-05-10 16:32:56 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-10 16:32:58 UTC) #4
dnj (Google)
Hmm to clarify, by "all" I mean "all non-Linux", the Linux ones work fine :)
4 years, 7 months ago (2016-05-10 16:33:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959063004/1
4 years, 7 months ago (2016-05-10 16:33:46 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-10 16:33:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959063004/1
4 years, 7 months ago (2016-05-10 16:34:16 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-10 16:34:18 UTC) #13
dnj
lgtm
4 years, 7 months ago (2016-05-10 16:34:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959063004/1
4 years, 7 months ago (2016-05-10 16:34:57 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 16:35:09 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300524

Powered by Google App Engine
This is Rietveld 408576698