Source/core/css/resolver/ScopedStyleResolver.h - Issue 195903002: Only process each StyleSheetContents once when collecting features during style resolution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/ScopedStyleResolver.h

Issue 195903002: Only process each StyleSheetContents once when collecting features during style resolution (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Only hash shared stylesheets Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « PerformanceTests/ShadowDOM/shadow-style-share-attr-selectors.html ('k') | Source/core/css/resolver/ScopedStyleResolver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/resolver/ScopedStyleResolver.h

diff --git a/Source/core/css/resolver/ScopedStyleResolver.h b/Source/core/css/resolver/ScopedStyleResolver.h

index 7cc3f51db0c20e0a003f1d1cc8db11fba081e6b6..5979088b471e032bf0ab7611631ac734c73b7a8a 100644

--- a/Source/core/css/resolver/ScopedStyleResolver.h

+++ b/Source/core/css/resolver/ScopedStyleResolver.h

@@ -31,6 +31,7 @@

#include "core/css/RuleSet.h"

#include "core/dom/ContainerNode.h"

#include "wtf/HashMap.h"

+#include "wtf/HashSet.h"

#include "wtf/OwnPtr.h"

#include "wtf/PassOwnPtr.h"

@@ -61,7 +62,7 @@ public:

void collectMatchingAuthorRules(ElementRuleCollector&, bool includeEmptyRules, bool applyAuthorStyles, CascadeScope, CascadeOrder = ignoreCascadeOrder);

void matchPageRules(PageRuleCollector&);

void addRulesFromSheet(CSSStyleSheet*, const MediaQueryEvaluator&, StyleResolver*);

- void collectFeaturesTo(RuleFeatureSet&);

+ void collectFeaturesTo(RuleFeatureSet&, HashSet<const StyleSheetContents*>& visitedSharedStyleSheetContents);

void resetAuthorStyle();

void collectViewportRulesTo(StyleResolver*) const;