Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1958973004: Always anchor to top of the anchor element (Closed)

Created:
4 years, 7 months ago by ymalik
Modified:
4 years, 7 months ago
Reviewers:
skobes
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always anchor to top of the anchor element Anchoring to the bottom corner results in unnecessary adjustment content is inserted above the anchor position but within the viewport. Always anchoring to the top has the problem that we wont adjust when content is inserted below the anchor position but above the viewport. The latter (not anchoring at all) is better than anchoring to the wrong position. This CL anchors to the top left for ltr and vertical-lr writing mode and top right for rtl and vertical-rl writing mode. BUG=600891, 594877 Committed: https://crrev.com/d91478719a0603374c12efbd79d9cd248770e7ad Cr-Commit-Position: refs/heads/master@{#392774}

Patch Set 1 #

Patch Set 2 : keep corner for rtl #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -17 lines) Patch
M third_party/WebKit/Source/core/layout/ScrollAnchor.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchor.cpp View 1 3 chunks +5 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp View 1 2 1 chunk +100 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
ymalik
4 years, 7 months ago (2016-05-09 18:31:49 UTC) #2
skobes
I wonder if we still need corner for RTL (crbug.com/594877)? Also can you add a ...
4 years, 7 months ago (2016-05-09 18:39:21 UTC) #3
ymalik
4 years, 7 months ago (2016-05-09 22:53:42 UTC) #5
skobes
lgtm
4 years, 7 months ago (2016-05-10 01:25:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958973004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958973004/40001
4 years, 7 months ago (2016-05-10 17:04:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/219062)
4 years, 7 months ago (2016-05-10 22:19:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958973004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958973004/40001
4 years, 7 months ago (2016-05-10 22:28:58 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-10 23:43:16 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 23:44:17 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d91478719a0603374c12efbd79d9cd248770e7ad
Cr-Commit-Position: refs/heads/master@{#392774}

Powered by Google App Engine
This is Rietveld 408576698