Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1958963002: Remove older and unused ScriptState methods. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove older and unused ScriptState methods. R= BUG= Committed: https://crrev.com/b1b5f36920b912f0071f2c27a0575d369183b675 Cr-Commit-Position: refs/heads/master@{#392316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptState.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-09 08:25:42 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-09 08:26:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958963002/1
4 years, 7 months ago (2016-05-09 13:54:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 15:00:15 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 15:01:10 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b1b5f36920b912f0071f2c27a0575d369183b675
Cr-Commit-Position: refs/heads/master@{#392316}

Powered by Google App Engine
This is Rietveld 408576698