Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1958953003: Remove unused AddGoogleAccountDialogFragment (Closed)

Created:
4 years, 7 months ago by gogerald1
Modified:
4 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused AddGoogleAccountDialogFragment We use Android add Google account pages. BUG=610478 Committed: https://crrev.com/bf3395431d65a2462ddc80a6187559a7090a79be Cr-Commit-Position: refs/heads/master@{#392591}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -57 lines) Patch
D chrome/android/java/src/org/chromium/chrome/browser/signin/AddGoogleAccountDialogFragment.java View 1 chunk +0 lines, -56 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958953003/1
4 years, 7 months ago (2016-05-09 21:58:53 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-09 23:04:05 UTC) #7
gogerald1
Hi, PTAL,
4 years, 7 months ago (2016-05-09 23:06:00 UTC) #9
Bernhard Bauer
lgtm
4 years, 7 months ago (2016-05-10 08:44:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958953003/1
4 years, 7 months ago (2016-05-10 13:45:07 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 13:48:41 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 13:50:55 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bf3395431d65a2462ddc80a6187559a7090a79be
Cr-Commit-Position: refs/heads/master@{#392591}

Powered by Google App Engine
This is Rietveld 408576698