Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1958943002: Typed CSSOM: Rename PositionValue to CSSPositionValue (Closed)

Created:
4 years, 7 months ago by rjwright
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename PositionValue to CSSPositionValue Changes in line with changes to the spec: https://drafts.css-houdini.org/css-typed-om-1/#positionvalue-objects Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=610159 BUG=610165 Committed: https://crrev.com/f26e4576ff44ff40d5487cf3122eb847eee580a7 Cr-Commit-Position: refs/heads/master@{#393180}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Messages

Total messages: 22 (12 generated)
rjwright
4 years, 7 months ago (2016-05-09 06:47:39 UTC) #3
meade_UTC10
lgtm
4 years, 7 months ago (2016-05-10 05:49:11 UTC) #5
Timothy Loh
lgtm
4 years, 7 months ago (2016-05-11 07:45:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958943002/1
4 years, 7 months ago (2016-05-12 01:46:02 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/4245) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-12 01:49:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958943002/20001
4 years, 7 months ago (2016-05-12 02:00:16 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/226338)
4 years, 7 months ago (2016-05-12 02:52:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958943002/40001
4 years, 7 months ago (2016-05-12 03:18:56 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-12 04:26:51 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 04:28:13 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f26e4576ff44ff40d5487cf3122eb847eee580a7
Cr-Commit-Position: refs/heads/master@{#393180}

Powered by Google App Engine
This is Rietveld 408576698