Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1958933003: Typed CSSOM: Rename Translation to CSSTranslation (Closed)

Created:
4 years, 7 months ago by rjwright
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Traslantion to CSSTranslation Changes in line with changes to the spec: https://drafts.css-houdini.org/css-typed-om-1/#csstranslation Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=610159 BUG=610168 Committed: https://crrev.com/364bcf4b0423ef5c520c0ca8dea2e9c23034a559 Cr-Commit-Position: refs/heads/master@{#393485}

Patch Set 1 #

Patch Set 2 : Remove the "TransformComponent" suffix. Will do others in subsequent patches. #

Patch Set 3 : fix layout test name #

Total comments: 1

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Messages

Total messages: 23 (11 generated)
rjwright
4 years, 7 months ago (2016-05-09 07:45:59 UTC) #3
meade_UTC10
lgtm
4 years, 7 months ago (2016-05-10 07:28:58 UTC) #6
Timothy Loh
Is there any reason to keep the TransformComponent suffix on the class?
4 years, 7 months ago (2016-05-11 06:50:14 UTC) #7
Timothy Loh
BTW theres a typo in the patch title Transla*n*tion
4 years, 7 months ago (2016-05-11 07:08:48 UTC) #8
rjwright
On 2016/05/11 06:50:14, Timothy Loh wrote: > Is there any reason to keep the TransformComponent ...
4 years, 7 months ago (2016-05-12 01:46:45 UTC) #9
Timothy Loh
lgtm On 2016/05/12 01:46:45, rjwright wrote: > On 2016/05/11 06:50:14, Timothy Loh wrote: > > ...
4 years, 7 months ago (2016-05-12 07:09:27 UTC) #10
Timothy Loh
https://codereview.chromium.org/1958933003/diff/40001/third_party/WebKit/Source/core/core.gypi File third_party/WebKit/Source/core/core.gypi (right): https://codereview.chromium.org/1958933003/diff/40001/third_party/WebKit/Source/core/core.gypi#newcode1344 third_party/WebKit/Source/core/core.gypi:1344: 'css/cssom/PositionValue.cpp', Don't move these files you're not renaming around ...
4 years, 7 months ago (2016-05-12 07:16:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958933003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958933003/60001
4 years, 7 months ago (2016-05-13 05:40:55 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/65435) ios-device on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-13 05:42:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958933003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958933003/80001
4 years, 7 months ago (2016-05-13 06:58:04 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-13 09:12:18 UTC) #21
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 09:14:14 UTC) #23
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/364bcf4b0423ef5c520c0ca8dea2e9c23034a559
Cr-Commit-Position: refs/heads/master@{#393485}

Powered by Google App Engine
This is Rietveld 408576698