Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 195893047: Remove FontDescription::isSpecifiedFont. (Closed)

Created:
6 years, 9 months ago by dglazkov
Modified:
6 years, 9 months ago
Reviewers:
eae, eseidel
CC:
blink-reviews, jamesr, krit, dsinclair, ed+blinkwatch_opera.com, jbroman, danakj, dglazkov+blink, Rik, apavlov+blink_chromium.org, darktears, Stephen Chennney, rune+blink, pdr., rwlbuis
Visibility:
Public.

Description

Remove FontDescription::isSpecifiedFont. We actually never use it in a meaningful way. R=eae,eseidel BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169586

Patch Set 1 #

Patch Set 2 : Updated bit count. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M Source/core/css/CSSFontSelector.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/FontBuilder.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/platform/fonts/FontDescription.h View 5 chunks +0 lines, -5 lines 0 comments Download
M Source/platform/fonts/FontDescription.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
dglazkov
6 years, 9 months ago (2014-03-19 19:57:42 UTC) #1
eae
On 2014/03/19 19:57:42, dglazkov wrote: You should update bitfields2 on line 45 in FontDescription.cpp to ...
6 years, 9 months ago (2014-03-19 20:00:32 UTC) #2
dglazkov
PTAL.
6 years, 9 months ago (2014-03-19 20:03:39 UTC) #3
eae
LGTM, thanks!
6 years, 9 months ago (2014-03-19 20:03:53 UTC) #4
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-19 20:03:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/195893047/20001
6 years, 9 months ago (2014-03-19 20:04:03 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 20:05:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-19 20:05:16 UTC) #8
dglazkov
The CQ bit was checked by dglazkov@chromium.org
6 years, 9 months ago (2014-03-19 21:27:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/195893047/20001
6 years, 9 months ago (2014-03-19 21:27:32 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 22:02:16 UTC) #11
Message was sent while issue was closed.
Change committed as 169586

Powered by Google App Engine
This is Rietveld 408576698