Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 195893044: Add a PPB_Find_Private function to set the tickmarks on the page. (Closed)

Created:
6 years, 9 months ago by raymes
Modified:
6 years, 8 months ago
Reviewers:
cmp, jschuh, yzshen1
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, jam, yzshen+watch_chromium.org, joi+watch-content_chromium.org, teravest+watch_chromium.org, darin-cc_chromium.org, raymes+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, binji, ihf+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Add a PPB_Find_Private function to set the tickmarks on the page. This adds a PPB_Find_Private function to set the tickmarks on the page. BUG=303491 TBR=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260443

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 26

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -3 lines) Patch
M content/renderer/pepper/pepper_plugin_instance_impl.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 2 3 2 chunks +19 lines, -0 lines 0 comments Download
M mojo/examples/pepper_container_app/plugin_instance.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/examples/pepper_container_app/plugin_instance.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M ppapi/api/private/ppb_find_private.idl View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M ppapi/c/private/ppb_find_private.h View 1 2 3 4 3 chunks +11 lines, -1 line 0 comments Download
M ppapi/cpp/private/find_private.h View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M ppapi/cpp/private/find_private.cc View 1 2 3 4 2 chunks +13 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 1 2 3 3 chunks +25 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_find_private_thunk.cc View 1 2 3 4 2 chunks +13 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_instance_api.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
raymes
6 years, 9 months ago (2014-03-19 02:45:56 UTC) #1
yzshen1
https://codereview.chromium.org/195893044/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.cc File content/renderer/pepper/pepper_plugin_instance_impl.cc (right): https://codereview.chromium.org/195893044/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.cc#newcode2425 content/renderer/pepper/pepper_plugin_instance_impl.cc:2425: const struct PP_Rect* tickmarks, nit: no need to have ...
6 years, 9 months ago (2014-03-19 17:38:05 UTC) #2
raymes
Thanks! +jschuh for ppapi_messages.h https://codereview.chromium.org/195893044/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.cc File content/renderer/pepper/pepper_plugin_instance_impl.cc (right): https://codereview.chromium.org/195893044/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.cc#newcode2425 content/renderer/pepper/pepper_plugin_instance_impl.cc:2425: const struct PP_Rect* tickmarks, On ...
6 years, 9 months ago (2014-03-20 01:53:55 UTC) #3
jschuh
ipc security lgtm.
6 years, 9 months ago (2014-03-21 05:08:40 UTC) #4
yzshen1
lgtm
6 years, 9 months ago (2014-03-21 05:10:55 UTC) #5
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 9 months ago (2014-03-26 06:27:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/195893044/60001
6 years, 9 months ago (2014-03-26 06:28:03 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 07:07:27 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 9 months ago (2014-03-26 07:07:27 UTC) #9
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 9 months ago (2014-03-26 23:37:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/195893044/250001
6 years, 9 months ago (2014-03-26 23:37:47 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 00:40:29 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=88646
6 years, 9 months ago (2014-03-27 00:40:29 UTC) #13
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 9 months ago (2014-03-27 00:53:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/195893044/250001
6 years, 9 months ago (2014-03-27 00:53:11 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 03:12:51 UTC) #16
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=88713
6 years, 9 months ago (2014-03-27 03:12:52 UTC) #17
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 9 months ago (2014-03-28 00:27:10 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/195893044/270001
6 years, 9 months ago (2014-03-28 00:29:50 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 01:09:54 UTC) #20
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58163
6 years, 9 months ago (2014-03-28 01:09:55 UTC) #21
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 9 months ago (2014-03-28 01:54:48 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/195893044/270001
6 years, 9 months ago (2014-03-28 01:57:18 UTC) #23
cmp
The CQ bit was unchecked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 16:41:01 UTC) #24
cmp
The CQ bit was checked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 16:43:14 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/195893044/270001
6 years, 8 months ago (2014-03-30 16:43:43 UTC) #26
commit-bot: I haz the power
6 years, 8 months ago (2014-03-30 17:21:14 UTC) #27
Message was sent while issue was closed. 
Change committed as 260443

Powered by Google App Engine
This is Rietveld 408576698