sdk/lib/io/file_impl.dart - Issue 195893012: Use a sync-writing StreamConsumer for stdout/stderr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/file_impl.dart

Issue 195893012: Use a sync-writing StreamConsumer for stdout/stderr. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/io/file_impl.dart

diff --git a/sdk/lib/io/file_impl.dart b/sdk/lib/io/file_impl.dart

index dfa75f6ebd181e7fe183d530b539f0685605e00b..71e3ffefd6c0b7203efb08a0c32d0c19bea8a336 100644

--- a/sdk/lib/io/file_impl.dart

+++ b/sdk/lib/io/file_impl.dart

@@ -181,11 +181,6 @@ class _FileStreamConsumer extends StreamConsumer<List<int>> {

_openFuture = _file.open(mode: mode);

}

- _FileStreamConsumer.fromStdio(int fd) {

- assert(1 <= fd && fd <= 2);

- _openFuture = new Future.value(_File._openStdioSync(fd));

- }

Future<File> addStream(Stream<List<int>> stream) {

Completer<File> completer = new Completer<File>();

_openFuture

« no previous file with comments | « runtime/bin/stdio_patch.dart ('k') | sdk/lib/io/stdio.dart » ('j') | no next file with comments »