Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1958913003: VM precompiler: Allow optimizing static initializers. (Closed)

Created:
4 years, 7 months ago by Florian Schneider
Modified:
4 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM precompiler: Allow optimizing static initializers. Static initializers were compiled without any optimizations. They are only executed once, but the optimizer can potentially extract static type information and may also produce a bit smaller code. (7K size savings when compiling dart2js -- i.e. < 0.1%) This CL enables optimizations for them. The space savings are not great, but I still think it's nicer to only have optimized code when precompiling, instead of a mixture of unoptimized and optimized. Also, fix printing disassembly for initializers, and insert additional assertions. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/245197fb9fd35359f16e65c11d2fff50cf9352de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -26 lines) Patch
M runtime/vm/compiler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M runtime/vm/precompiler.cc View 8 chunks +27 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Florian Schneider
Ptal. This is something I tried some time ago, but did not finish back then ...
4 years, 7 months ago (2016-05-09 17:57:11 UTC) #5
rmacnak
lgtm
4 years, 7 months ago (2016-05-09 22:24:03 UTC) #6
Florian Schneider
4 years, 7 months ago (2016-05-10 07:38:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
245197fb9fd35359f16e65c11d2fff50cf9352de.

Powered by Google App Engine
This is Rietveld 408576698