Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

Issue 1958903005: Fix positioning of Browser Plugins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix positioning problem and update test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc b/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
index c8a839c0b6e1d07ab6e1b6a86c883575165f4005..15b2349e863d414b21ab5f5f11115e8589aa3a40 100644
--- a/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
@@ -392,8 +392,8 @@ class WebViewInteractiveTestBase : public extensions::PlatformAppBrowserTest {
LOG(INFO) << "DIFF: x = " << diff.x() << ", y = " << diff.y();
const int left_spacing = 40 + padding.x(); // div.style.paddingLeft = 40px.
- // div.style.paddingTop = 50px + (input box height = 26px).
- const int top_spacing = 50 + 26 + padding.y();
+ // div.style.paddingTop = 60px + (input box height = 26px).
Stephen Chennney 2016/05/10 18:40:22 The paddingTop in the test file is actually 60px,
lazyboy 2016/05/10 20:51:58 wow! thanks!
+ const int top_spacing = 60 + 26 + padding.y();
// If the popup is placed within |threshold_px| of the expected position,
// then we consider the test as a pass.
« no previous file with comments | « no previous file | content/renderer/browser_plugin/browser_plugin.cc » ('j') | content/renderer/browser_plugin/browser_plugin.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698