Fix positioning of Browser Plugins

content/renderer/browser_plugin/browser_plugin.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/browser_plugin/browser_plugin.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/command_line.h"
@@ skipping 364 matching lines @@
       delegate_->Ready();
     ready_ = true;
   }
 
   if (delegate_ && (view_rect_.size() != old_view_rect.size()))
     delegate_->DidResizeElement(view_rect_.size());
 
   if (!attached())
     return;
 
-  if (old_view_rect.size() == view_rect_.size()) {

[Stephen Chennney, 2016/05/10 18:40:23]

This very odd condition is a remnant of
https://chromium.googlesource.com/chromium/src/+/32deec6509deb789265c50ba2943...,
much moved since then. It was revealed by a recent change to prevent double
calls to updateGeometry, which are wasteful.

[lazyboy, 2016/05/10 20:51:58]

Which change was that?
which are wasteful.

The intention here IIRC was when plugin was not resized but its position (x,y)
changed, we wanted to send the rect to browser/ process in this case.
What you have still accomplishes the same and but a bit more.
In case where the size have changed (but x, y didn't), we would send an IPC
through GuestViewContainer in line 380 above:
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/browser...
and then an IPC here, which wasn't necessary.

Maybe instead you need
if (old_view_rect != view_rect_ && old.size() == view_rect_.size())
Would that accomplish our goal here?

+  if (old_view_rect != view_rect_) {
     // Let the browser know about the updated view rect.
     BrowserPluginManager::Get()->Send(new BrowserPluginHostMsg_UpdateGeometry(
         browser_plugin_instance_id_, view_rect_));
     return;
   }
 }
 
 void BrowserPlugin::updateFocus(bool focused, blink::WebFocusType focus_type) {
   plugin_focused_ = focused;
   UpdateGuestFocusState(focus_type);
@@ skipping 171 matching lines @@
 
 bool BrowserPlugin::HandleMouseLockedInputEvent(
     const blink::WebMouseEvent& event) {
   BrowserPluginManager::Get()->Send(
       new BrowserPluginHostMsg_HandleInputEvent(browser_plugin_instance_id_,
                                                 &event));
   return true;
 }
 
 }  // namespace content