Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 19589004: Cleanup: Normalize liscence headers in modules/crypto/*. (Closed)

Created:
7 years, 5 months ago by eroman
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Cleanup: Normalize liscence headers in modules/crypto/*. Before there were 4 different styles of headers: (style A): 25 (style B): 4 (style C): 2 (style D): 1 After this change, there are only 2 styles of headers: (style A): 29 (style B): 3 (Crypto.idl, Crypto.h, Crypto.cpp) All of the files using (style A) are ones which I added while working on WebCrypto, so there shouldn't be any issues with changing them. The files using (style B) are ones which predated my work so I decided to left them untouched. BUG=245025 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154437

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -79 lines) Patch
M Source/modules/crypto/Crypto.idl View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.h View 1 1 chunk +22 lines, -20 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.cpp View 1 1 chunk +22 lines, -20 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.idl View 1 chunk +22 lines, -20 lines 0 comments Download
M Source/modules/crypto/WindowCrypto.idl View 1 chunk +21 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eroman
Adam, is this something I am even allowed to do? If not I can just ...
7 years, 5 months ago (2013-07-17 20:13:17 UTC) #1
abarth-chromium
lgtm Should be fine. These are all copyrights owned by Google.
7 years, 5 months ago (2013-07-17 20:20:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/19589004/1
7 years, 5 months ago (2013-07-17 20:22:43 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, weborigin_unittests, wtf_unittests ...
7 years, 5 months ago (2013-07-17 21:49:53 UTC) #4
eroman
7 years, 5 months ago (2013-07-17 22:16:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r154437 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698