Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: tests/standalone/io/test_runner_test.dart

Issue 19589002: Fixed skipping_dart2js_compilations_test after changing Command() constructor (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/standalone/io/skipping_dart2js_compilations_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import "dart:io"; 5 import "dart:io";
6 import "dart:isolate"; 6 import "dart:isolate";
7 import "dart:async"; 7 import "dart:async";
8 import "dart:utf"; 8 import "dart:utf";
9 import "../../../tools/testing/dart/test_runner.dart"; 9 import "../../../tools/testing/dart/test_runner.dart";
10 import "../../../tools/testing/dart/test_suite.dart"; 10 import "../../../tools/testing/dart/test_suite.dart";
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 enqueueTestCase(testCaseFail); 64 enqueueTestCase(testCaseFail);
65 enqueueTestCase(testCaseTimeout); 65 enqueueTestCase(testCaseTimeout);
66 enqueueTestCase(testCaseFailUnexpected); 66 enqueueTestCase(testCaseFailUnexpected);
67 67
68 if (onDone != null) { 68 if (onDone != null) {
69 onDone(); 69 onDone();
70 } 70 }
71 } 71 }
72 72
73 TestCase _makeNormalTestCase(name, expectations) { 73 TestCase _makeNormalTestCase(name, expectations) {
74 var command = new Command(Platform.executable, 74 var command = new Command('custom',
75 Platform.executable,
75 [Platform.script, name]); 76 [Platform.script, name]);
76 return _makeTestCase(name, DEFAULT_TIMEOUT, command, expectations); 77 return _makeTestCase(name, DEFAULT_TIMEOUT, command, expectations);
77 } 78 }
78 79
79 _makeCrashTestCase(name, expectations) { 80 _makeCrashTestCase(name, expectations) {
80 var crashCommand = new Command(getProcessTestFileName(), 81 var crashCommand = new Command('custom_crash',
82 getProcessTestFileName(),
81 ["0", "0", "1", "1"]); 83 ["0", "0", "1", "1"]);
82 // The crash test sometimes times out. Run it with a large timeout 84 // The crash test sometimes times out. Run it with a large timeout
83 // to help diagnose the delay. 85 // to help diagnose the delay.
84 // The test loads a new executable, which may sometimes take a long time. 86 // The test loads a new executable, which may sometimes take a long time.
85 // It involves a wait on the VM event loop, and possible system 87 // It involves a wait on the VM event loop, and possible system
86 // delays. 88 // delays.
87 return _makeTestCase(name, LONG_TIMEOUT, crashCommand, expectations); 89 return _makeTestCase(name, LONG_TIMEOUT, crashCommand, expectations);
88 } 90 }
89 91
90 _makeTestCase(name, timeout, command, expectations) { 92 _makeTestCase(name, timeout, command, expectations) {
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 break; 124 break;
123 case 'timeout': 125 case 'timeout':
124 // Run for 10 seconds, then exit. This tests a 2 second timeout. 126 // Run for 10 seconds, then exit. This tests a 2 second timeout.
125 new Timer(new Duration(seconds: 10), (){ }); 127 new Timer(new Duration(seconds: 10), (){ });
126 break; 128 break;
127 default: 129 default:
128 throw "Unknown option ${arguments[0]} passed to test_runner_test"; 130 throw "Unknown option ${arguments[0]} passed to test_runner_test";
129 } 131 }
130 } 132 }
131 } 133 }
OLDNEW
« no previous file with comments | « tests/standalone/io/skipping_dart2js_compilations_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698