Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1958863003: X87: Revert of [turbofan] Take the immediate size in account when narrowing ia32/x64 word compariso… (Closed)

Created:
4 years, 7 months ago by zhengxing.li
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Revert of [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. (patchset #2 id:20001 of https://codereview.chromium.org/1948453002/ ). port 3b7ff999f3a9b33945b77787ba85251e42939ac0 (r36066) original commit message: Reason for revert: Breaks WASM; please also add tests when relanding. Original issue's description: > [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. > > Before this patch, we would emit a cmp or test with a memory operand only if both of the operands in the IR were loads. Now if either of them is a load and the other one is an immediate, we can use a > > Committed: https://crrev.com/a0543313dbd46b0c2e72c91ee3488a7dc6db73e4 > Cr-Commit-Position: refs/heads/master@{#36009} BUG= Committed: https://crrev.com/80a8c3f519a8904c1cec63460ffaab240fa08af6 Cr-Commit-Position: refs/heads/master@{#36094}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -58 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 3 chunks +13 lines, -58 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 7 months ago (2016-05-09 02:31:28 UTC) #2
Weiliang
lgtm
4 years, 7 months ago (2016-05-09 02:39:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958863003/1
4 years, 7 months ago (2016-05-09 02:40:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 03:00:25 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 03:02:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80a8c3f519a8904c1cec63460ffaab240fa08af6
Cr-Commit-Position: refs/heads/master@{#36094}

Powered by Google App Engine
This is Rietveld 408576698