ipc/ipc_message_attachment_set_posix_unittest.cc - Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_message_attachment_set_posix_unittest.cc

Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/bluez/bluetooth_advertisement_bluez_unittest.cc ('K') | « ios/web/web_state/ui/crw_web_controller.mm ('k') | media/blink/video_frame_compositor.cc » ('j') | ppapi/tests/ppapi_nacl_tests_newlib.nmf » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ipc/ipc_message_attachment_set_posix_unittest.cc

diff --git a/ipc/ipc_message_attachment_set_posix_unittest.cc b/ipc/ipc_message_attachment_set_posix_unittest.cc

index e43e43163cb626053371bf655f969ff493e92b14..5ebed84070ce3748485a231c040839ff9a5c7755 100644

--- a/ipc/ipc_message_attachment_set_posix_unittest.cc

+++ b/ipc/ipc_message_attachment_set_posix_unittest.cc

@@ -154,7 +154,7 @@ TEST(MessageAttachmentSet, WalkWrongOrder) {

set->AddAttachment(new internal::PlatformFileAttachment(kFDBase + 2)));

ASSERT_EQ(set->GetNonBrokerableAttachmentAt(0)->TakePlatformFile(), kFDBase);

- ASSERT_EQ(set->GetNonBrokerableAttachmentAt(2), nullptr);

+ ASSERT_FALSE(set->GetNonBrokerableAttachmentAt(2));

set->CommitAllDescriptors();

}