base/threading/thread_unittest.cc - Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/thread_unittest.cc

Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/threading/thread_unittest.cc

diff --git a/base/threading/thread_unittest.cc b/base/threading/thread_unittest.cc

index d273dc076c9d23a0da1d1e53f087ef9a7b34ae54..7bf83f81a45cd15061622a89d7fb0d0e5d74f5a6 100644

--- a/base/threading/thread_unittest.cc

+++ b/base/threading/thread_unittest.cc

@@ -291,7 +291,7 @@ TEST_F(ThreadTest, CleanUp) {

TEST_F(ThreadTest, ThreadNotStarted) {

Thread a("Inert");

- EXPECT_EQ(nullptr, a.task_runner());

+ EXPECT_FALSE(a.task_runner());

}

TEST_F(ThreadTest, MultipleWaitUntilThreadStarted) {

« base/memory/ref_counted.h ('K') | « base/memory/ref_counted.h ('k') | blimp/common/blob_cache/in_memory_blob_cache_unittest.cc » ('j') | chrome/browser/themes/theme_service.cc » ('J')