content/browser/media/webrtc/webrtc_internals.cc - Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/webrtc/webrtc_internals.cc

Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Splitting out change to scoped_refptr to follow up patch. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/gpu_process_transport_factory.cc ('k') | content/browser/renderer_host/compositor_impl_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/webrtc/webrtc_internals.cc

diff --git a/content/browser/media/webrtc/webrtc_internals.cc b/content/browser/media/webrtc/webrtc_internals.cc

index 1ebc884a5cb0a7816f607c31ddd38dc9ebedd0b0..09d7a970d26052e49cedf927f7bf87711bfb1c1a 100644

--- a/content/browser/media/webrtc/webrtc_internals.cc

+++ b/content/browser/media/webrtc/webrtc_internals.cc

@@ -278,7 +278,7 @@ void WebRTCInternals::EnableAudioDebugRecordings(

EnableAudioDebugRecordingsOnAllRenderProcessHosts();

#else

selecting_event_log_ = false;

- DCHECK(select_file_dialog_ == nullptr);

+ DCHECK(!select_file_dialog_);

select_file_dialog_ = ui::SelectFileDialog::Create(this, NULL);

select_file_dialog_->SelectFile(

ui::SelectFileDialog::SELECT_SAVEAS_FILE,

@@ -330,7 +330,7 @@ void WebRTCInternals::SetEventLogRecordings(

EnableEventLogRecordingsOnAllRenderProcessHosts();

#else

DCHECK(web_contents);

- DCHECK(select_file_dialog_ == nullptr);

+ DCHECK(!select_file_dialog_);

selecting_event_log_ = true;

select_file_dialog_ = ui::SelectFileDialog::Create(this, nullptr);

select_file_dialog_->SelectFile(