components/tracing/child_memory_dump_manager_delegate_impl.cc - Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/child_memory_dump_manager_delegate_impl.cc

Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Splitting out change to scoped_refptr to follow up patch. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/tracing/child_memory_dump_manager_delegate_impl.cc

diff --git a/components/tracing/child_memory_dump_manager_delegate_impl.cc b/components/tracing/child_memory_dump_manager_delegate_impl.cc

index ced940b2295c506bc1ffe376e96d343627d3e647..47711eb91be5b3e24a4dbfd5e4ff24b41944f946 100644

--- a/components/tracing/child_memory_dump_manager_delegate_impl.cc

+++ b/components/tracing/child_memory_dump_manager_delegate_impl.cc

@@ -40,7 +40,7 @@ void ChildMemoryDumpManagerDelegateImpl::SetChildTraceMessageFilter(

const auto& task_runner = ctmf ? (ctmf->ipc_task_runner()) : nullptr;

// Check that we are either registering the CTMF or tearing it down, but not

// replacing a valid instance with another one (should never happen).

- DCHECK(ctmf_ == nullptr || (ctmf == nullptr && ctmf_task_runner_ != nullptr));

+ DCHECK(!ctmf_ || (!ctmf && ctmf_task_runner_));

ctmf_ = ctmf;

{

« no previous file with comments | « components/suggestions/image_manager_unittest.cc ('k') | content/browser/cache_storage/cache_storage.cc » ('j') | no next file with comments »