chrome/browser/ui/webui/options/password_manager_handler.cc - Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/password_manager_handler.cc

Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Splitting out change to scoped_refptr to follow up patch. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/options/password_manager_handler.cc

diff --git a/chrome/browser/ui/webui/options/password_manager_handler.cc b/chrome/browser/ui/webui/options/password_manager_handler.cc

index c55d106d123b25aa03ecafabcebf8af23dd73808..97e1f611947c8509e01e21423beff5889b95394f 100644

--- a/chrome/browser/ui/webui/options/password_manager_handler.cc

+++ b/chrome/browser/ui/webui/options/password_manager_handler.cc

@@ -374,7 +374,7 @@ void PasswordManagerHandler::ImportPasswordResultConsumer::ConsumePassword(

}

UMA_HISTOGRAM_BOOLEAN("PasswordManager.StorePasswordImportedFromCSVResult",

- store);

+ static_cast<bool>(store));

}

void PasswordManagerHandler::HandlePasswordExport(const base::ListValue* args) {

« no previous file with comments | « chrome/browser/ui/views/certificate_selector_browsertest.cc ('k') | components/drive/drive_uploader.cc » ('j') | no next file with comments »