blimp/common/blob_cache/in_memory_blob_cache_unittest.cc - Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/common/blob_cache/in_memory_blob_cache_unittest.cc

Issue 1958823002: Fix implicit access to raw pointer of scoped_refptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Splitting out change to scoped_refptr to follow up patch. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/common/blob_cache/in_memory_blob_cache_unittest.cc

diff --git a/blimp/common/blob_cache/in_memory_blob_cache_unittest.cc b/blimp/common/blob_cache/in_memory_blob_cache_unittest.cc

index 828c395a9ce207e846e86bc3ffb86f19647aa58a..6eb98ff6c4aa39387418505dde296dedbe9f8822 100644

--- a/blimp/common/blob_cache/in_memory_blob_cache_unittest.cc

+++ b/blimp/common/blob_cache/in_memory_blob_cache_unittest.cc

@@ -36,7 +36,7 @@ class InMemoryBlobCacheTest : public testing::Test {

TEST_F(InMemoryBlobCacheTest, SimplePutContainsAndGetOperations) {

EXPECT_FALSE(cache_.Contains(kFoo));

- EXPECT_EQ(nullptr, cache_.Get(kFoo));

+ EXPECT_FALSE(cache_.Get(kFoo));

BlobDataPtr blob_data = CreateBlobDataPtr(kDeadbeef);

cache_.Put(kFoo, blob_data);

« no previous file with comments | « base/threading/thread_unittest.cc ('k') | cc/test/fake_video_frame_provider.cc » ('j') | no next file with comments »