Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1958803003: sync compostor: Return resources async IPC (Closed)

Created:
4 years, 7 months ago by boliu
Modified:
4 years, 7 months ago
Reviewers:
hush (inactive), dcheng
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sync compostor: Return resources async IPC Small step toward overall refactor outlined in bug. Make returning resources an plain old async IPC that's sent whenever there are return resources, and remove it from CommonBrowserParams that's sent in every IPC. On the renderer side, add OnMessageReceived to OutputSurface, and have OuputSurface get the first chance of handling IPCs before Proxy. Eventual aim is Proxy should not handle any IPC and should just be removed. BUG=609977 Committed: https://crrev.com/ec72a2edffebb31179ed7b1812ecb94509f8adfe Cr-Commit-Position: refs/heads/master@{#392499}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -38 lines) Patch
M content/browser/android/synchronous_compositor_host.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/android/synchronous_compositor_host.cc View 4 chunks +3 lines, -16 lines 0 comments Download
M content/common/android/sync_compositor_messages.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/common/android/sync_compositor_messages.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/android/synchronous_compositor_output_surface.h View 3 chunks +5 lines, -6 lines 2 comments Download
M content/renderer/android/synchronous_compositor_output_surface.cc View 3 chunks +20 lines, -4 lines 0 comments Download
M content/renderer/android/synchronous_compositor_proxy.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
boliu
ptal dcheng for ipc hush for the rest
4 years, 7 months ago (2016-05-07 00:22:24 UTC) #2
dcheng
rs lgtm for ipc changes
4 years, 7 months ago (2016-05-07 06:02:18 UTC) #3
hush (inactive)
lgtm I supposed you are gonna do this IPC by IPC? https://codereview.chromium.org/1958803003/diff/1/content/renderer/android/synchronous_compositor_output_surface.h File content/renderer/android/synchronous_compositor_output_surface.h (left): ...
4 years, 7 months ago (2016-05-09 23:52:10 UTC) #4
boliu
On 2016/05/09 23:52:10, hush wrote: > lgtm > > I supposed you are gonna do ...
4 years, 7 months ago (2016-05-10 00:00:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958803003/1
4 years, 7 months ago (2016-05-10 00:01:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 00:52:12 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 00:53:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec72a2edffebb31179ed7b1812ecb94509f8adfe
Cr-Commit-Position: refs/heads/master@{#392499}

Powered by Google App Engine
This is Rietveld 408576698