Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Side by Side Diff: src/x64/stub-cache-x64.cc

Issue 19588002: Fixed type feedback in presence of negative lookups. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Added TODOs Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/stub-cache-mips.cc ('k') | test/mjsunit/regress/regress-252797.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1041 matching lines...) Expand 10 before | Expand all | Expand 10 after
1052 Register StubCompiler::CheckPrototypes(Handle<JSObject> object, 1052 Register StubCompiler::CheckPrototypes(Handle<JSObject> object,
1053 Register object_reg, 1053 Register object_reg,
1054 Handle<JSObject> holder, 1054 Handle<JSObject> holder,
1055 Register holder_reg, 1055 Register holder_reg,
1056 Register scratch1, 1056 Register scratch1,
1057 Register scratch2, 1057 Register scratch2,
1058 Handle<Name> name, 1058 Handle<Name> name,
1059 int save_at_depth, 1059 int save_at_depth,
1060 Label* miss, 1060 Label* miss,
1061 PrototypeCheckType check) { 1061 PrototypeCheckType check) {
1062 // Make sure that the type feedback oracle harvests the receiver map.
1063 // TODO(svenpanne) Remove this hack when all ICs are reworked.
1064 __ Move(scratch1, Handle<Map>(object->map()));
1065
1062 Handle<JSObject> first = object; 1066 Handle<JSObject> first = object;
1063 // Make sure there's no overlap between holder and object registers. 1067 // Make sure there's no overlap between holder and object registers.
1064 ASSERT(!scratch1.is(object_reg) && !scratch1.is(holder_reg)); 1068 ASSERT(!scratch1.is(object_reg) && !scratch1.is(holder_reg));
1065 ASSERT(!scratch2.is(object_reg) && !scratch2.is(holder_reg) 1069 ASSERT(!scratch2.is(object_reg) && !scratch2.is(holder_reg)
1066 && !scratch2.is(scratch1)); 1070 && !scratch2.is(scratch1));
1067 1071
1068 // Keep track of the current object in register reg. On the first 1072 // Keep track of the current object in register reg. On the first
1069 // iteration, reg is an alias for object_reg, on later iterations, 1073 // iteration, reg is an alias for object_reg, on later iterations,
1070 // it is an alias for holder_reg. 1074 // it is an alias for holder_reg.
1071 Register reg = object_reg; 1075 Register reg = object_reg;
(...skipping 2438 matching lines...) Expand 10 before | Expand all | Expand 10 after
3510 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow); 3514 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow);
3511 } 3515 }
3512 } 3516 }
3513 3517
3514 3518
3515 #undef __ 3519 #undef __
3516 3520
3517 } } // namespace v8::internal 3521 } } // namespace v8::internal
3518 3522
3519 #endif // V8_TARGET_ARCH_X64 3523 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/stub-cache-mips.cc ('k') | test/mjsunit/regress/regress-252797.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698