Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 19588002: Fixed type feedback in presence of negative lookups. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Added TODOs Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/mips/stub-cache-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1114 matching lines...) Expand 10 before | Expand all | Expand 10 after
1125 Register StubCompiler::CheckPrototypes(Handle<JSObject> object, 1125 Register StubCompiler::CheckPrototypes(Handle<JSObject> object,
1126 Register object_reg, 1126 Register object_reg,
1127 Handle<JSObject> holder, 1127 Handle<JSObject> holder,
1128 Register holder_reg, 1128 Register holder_reg,
1129 Register scratch1, 1129 Register scratch1,
1130 Register scratch2, 1130 Register scratch2,
1131 Handle<Name> name, 1131 Handle<Name> name,
1132 int save_at_depth, 1132 int save_at_depth,
1133 Label* miss, 1133 Label* miss,
1134 PrototypeCheckType check) { 1134 PrototypeCheckType check) {
1135 // Make sure that the type feedback oracle harvests the receiver map.
1136 // TODO(svenpanne) Remove this hack when all ICs are reworked.
1137 __ mov(scratch1, Handle<Map>(object->map()));
1138
1135 Handle<JSObject> first = object; 1139 Handle<JSObject> first = object;
1136 // Make sure there's no overlap between holder and object registers. 1140 // Make sure there's no overlap between holder and object registers.
1137 ASSERT(!scratch1.is(object_reg) && !scratch1.is(holder_reg)); 1141 ASSERT(!scratch1.is(object_reg) && !scratch1.is(holder_reg));
1138 ASSERT(!scratch2.is(object_reg) && !scratch2.is(holder_reg) 1142 ASSERT(!scratch2.is(object_reg) && !scratch2.is(holder_reg)
1139 && !scratch2.is(scratch1)); 1143 && !scratch2.is(scratch1));
1140 1144
1141 // Keep track of the current object in register reg. 1145 // Keep track of the current object in register reg.
1142 Register reg = object_reg; 1146 Register reg = object_reg;
1143 Handle<JSObject> current = object; 1147 Handle<JSObject> current = object;
1144 int depth = 0; 1148 int depth = 0;
(...skipping 2619 matching lines...) Expand 10 before | Expand all | Expand 10 after
3764 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow); 3768 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow);
3765 } 3769 }
3766 } 3770 }
3767 3771
3768 3772
3769 #undef __ 3773 #undef __
3770 3774
3771 } } // namespace v8::internal 3775 } } // namespace v8::internal
3772 3776
3773 #endif // V8_TARGET_ARCH_IA32 3777 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/mips/stub-cache-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698