Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 19588002: Fixed type feedback in presence of negative lookups. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Added TODOs Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1167 matching lines...) Expand 10 before | Expand all | Expand 10 after
1178 Register StubCompiler::CheckPrototypes(Handle<JSObject> object, 1178 Register StubCompiler::CheckPrototypes(Handle<JSObject> object,
1179 Register object_reg, 1179 Register object_reg,
1180 Handle<JSObject> holder, 1180 Handle<JSObject> holder,
1181 Register holder_reg, 1181 Register holder_reg,
1182 Register scratch1, 1182 Register scratch1,
1183 Register scratch2, 1183 Register scratch2,
1184 Handle<Name> name, 1184 Handle<Name> name,
1185 int save_at_depth, 1185 int save_at_depth,
1186 Label* miss, 1186 Label* miss,
1187 PrototypeCheckType check) { 1187 PrototypeCheckType check) {
1188 // Make sure that the type feedback oracle harvests the receiver map.
1189 // TODO(svenpanne) Remove this hack when all ICs are reworked.
1190 __ mov(scratch1, Operand(Handle<Map>(object->map())));
1191
1188 Handle<JSObject> first = object; 1192 Handle<JSObject> first = object;
1189 // Make sure there's no overlap between holder and object registers. 1193 // Make sure there's no overlap between holder and object registers.
1190 ASSERT(!scratch1.is(object_reg) && !scratch1.is(holder_reg)); 1194 ASSERT(!scratch1.is(object_reg) && !scratch1.is(holder_reg));
1191 ASSERT(!scratch2.is(object_reg) && !scratch2.is(holder_reg) 1195 ASSERT(!scratch2.is(object_reg) && !scratch2.is(holder_reg)
1192 && !scratch2.is(scratch1)); 1196 && !scratch2.is(scratch1));
1193 1197
1194 // Keep track of the current object in register reg. 1198 // Keep track of the current object in register reg.
1195 Register reg = object_reg; 1199 Register reg = object_reg;
1196 int depth = 0; 1200 int depth = 0;
1197 1201
(...skipping 2490 matching lines...) Expand 10 before | Expand all | Expand 10 after
3688 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow); 3692 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow);
3689 } 3693 }
3690 } 3694 }
3691 3695
3692 3696
3693 #undef __ 3697 #undef __
3694 3698
3695 } } // namespace v8::internal 3699 } } // namespace v8::internal
3696 3700
3697 #endif // V8_TARGET_ARCH_ARM 3701 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698