Test cancelling card unmasking dialog.

Test cancelling card unmasking dialog.

This is an integration test for PaymentRequest. It performs the
following actions in order:

1) Show the PaymentRequest UI with one credit card.
2) Click PAY button on PaymentRequest UI.
3) Click CANCEL button on CVC prompt.

BUG=608223
Committed: https://crrev.com/97d622c381750f28ad3dc3d3ff42f8d65e5c5d2f
Cr-Commit-Position: refs/heads/master@{#392223}

[please use gerrit instead, 2016-05-06 23:26:17]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2016-05-06 23:26:18]

dfalcantara@, ptal patch 2.

https://codereview.chromium.org/1958793002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
(right):

https://codereview.chromium.org/1958793002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:147:
private static PaymentRequestObserverForTest sObserverForTest;
I can't spel.

[gone, 2016-05-06 23:36:36]

Clever reuse of that class.

lgtm % nits

https://codereview.chromium.org/1958793002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
(right):

https://codereview.chromium.org/1958793002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:147:
private static PaymentRequestObserverForTest sObserverForTest;
On 2016/05/06 23:26:18, Rouslan wrote:
> I can't spel.

Lol, looked legit to me the first time around.

https://codereview.chromium.org/1958793002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:767:
if (isAcceptingUserInput() && mPayButton.isEnabled() && mObserverForTest !=
null) {
nit: Maybe the initial checks here should be for whether the observer is
non-null?  Early exits for regular browser usage.

https://codereview.chromium.org/1958793002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
(right):

https://codereview.chromium.org/1958793002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:98:
protected void cancelDialogAndWait(final CardUnmaskPrompt prompt, CallbackHelper
helper)
cancelCardUnmaskDialogAndWait?  Makes it clearer why you aren't using the one
above this.

[please use gerrit instead, 2016-05-07 00:01:14]

Sending to cq.

https://codereview.chromium.org/1958793002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
(right):

https://codereview.chromium.org/1958793002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:147:
private static PaymentRequestObserverForTest sObserverForTest;
On 2016/05/06 23:36:36, dfalcantara wrote:
> On 2016/05/06 23:26:18, Rouslan wrote:
> > I can't spel.
> 
> Lol, looked legit to me the first time around.

Done.

https://codereview.chromium.org/1958793002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:767:
if (isAcceptingUserInput() && mPayButton.isEnabled() && mObserverForTest !=
null) {
On 2016/05/06 23:36:36, dfalcantara wrote:
> nit: Maybe the initial checks here should be for whether the observer is
> non-null?  Early exits for regular browser usage.

Done.

https://codereview.chromium.org/1958793002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
(right):

https://codereview.chromium.org/1958793002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:98:
protected void cancelDialogAndWait(final CardUnmaskPrompt prompt, CallbackHelper
helper)
On 2016/05/06 23:36:36, dfalcantara wrote:
> cancelCardUnmaskDialogAndWait?  Makes it clearer why you aren't using the one
> above this.

Done.

[please use gerrit instead, 2016-05-07 00:01:30]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-05-07 00:01:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1958793002/#ps40001
(title: "Address comments/")

[commit-bot: I haz the power, 2016-05-07 00:01:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1958793002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1958793002/40001

[commit-bot: I haz the power, 2016-05-07 00:49:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-07 00:51:48]

Description was changed from

==========
Test cancelling card unmasking dialog.

This is an integration test for PaymentRequest. It performs the
following actions in order:

1) Show the PaymentRequest UI with one credit card.
2) Click PAY button on PaymentRequest UI.
3) Click CANCEL button on CVC prompt.

BUG=608223
==========

to

==========
Test cancelling card unmasking dialog.

This is an integration test for PaymentRequest. It performs the
following actions in order:

1) Show the PaymentRequest UI with one credit card.
2) Click PAY button on PaymentRequest UI.
3) Click CANCEL button on CVC prompt.

BUG=608223

Committed: https://crrev.com/97d622c381750f28ad3dc3d3ff42f8d65e5c5d2f
Cr-Commit-Position: refs/heads/master@{#392223}
==========

[commit-bot: I haz the power, 2016-05-07 00:51:49]

Patchset 3 (id:??) landed as
https://crrev.com/97d622c381750f28ad3dc3d3ff42f8d65e5c5d2f
Cr-Commit-Position: refs/heads/master@{#392223}