Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: tools/gn/ninja_build_writer.h

Issue 1958783003: GN: Prefer toplevel targets for phony names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/ninja_build_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_build_writer.h
diff --git a/tools/gn/ninja_build_writer.h b/tools/gn/ninja_build_writer.h
index 0d5b40eef70fe60d330cd91203e36cbcd4b172f0..e94f93de24e60ce5ec215a9ec15e40c42b9b32ba 100644
--- a/tools/gn/ninja_build_writer.h
+++ b/tools/gn/ninja_build_writer.h
@@ -46,12 +46,7 @@ class NinjaBuildWriter {
void WriteSubninjas();
bool WritePhonyAndAllRules(Err* err);
- // Writes a phony rule for the given target with the given name. Adds the new
- // name to the given set. If the name is already in the set, does nothing.
- void WritePhonyRule(const Target* target,
- const OutputFile& target_file,
- const std::string& phony_name,
- std::set<std::string>* written_rules);
+ void WritePhonyRule(const Target* target, const std::string& phony_name);
const BuildSettings* build_settings_;
std::vector<const Settings*> all_settings_;
« no previous file with comments | « no previous file | tools/gn/ninja_build_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698