Issue 1958733002: Suggest 'is' in 'if (x is^)'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1958733002: Suggest 'is' in 'if (x is^)'. (Closed)

Created:
4 years, 7 months ago by scheglov

Modified:
4 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Suggest 'is' in 'if (x is^)'. So, we don't treat is as an expression start, and don't suggest inappropriate 'while', 'await', etc or identifiers. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/cf71ab114b7769217ff50956f65035e3167d40fd

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 7 months ago (2016-05-06 21:36:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
cf71ab114b7769217ff50956f65035e3167d40fd (presubmit successful).