Index: chrome/browser/sync/profile_sync_service_startup_unittest.cc |
diff --git a/chrome/browser/sync/profile_sync_service_startup_unittest.cc b/chrome/browser/sync/profile_sync_service_startup_unittest.cc |
index a381bf004b584274fe8285c92fc1fc402fc547f8..58c2f4bbfaa16539434b0b2edde5caef423bde83 100644 |
--- a/chrome/browser/sync/profile_sync_service_startup_unittest.cc |
+++ b/chrome/browser/sync/profile_sync_service_startup_unittest.cc |
@@ -17,12 +17,13 @@ |
#include "chrome/browser/sync/profile_sync_components_factory_mock.h" |
#include "chrome/browser/sync/profile_sync_service_factory.h" |
#include "chrome/browser/sync/profile_sync_test_util.h" |
-#include "chrome/browser/sync/sync_prefs.h" |
#include "chrome/common/pref_names.h" |
#include "chrome/test/base/testing_profile.h" |
#include "components/signin/core/profile_oauth2_token_service.h" |
#include "components/sync_driver/data_type_manager.h" |
#include "components/sync_driver/data_type_manager_mock.h" |
+#include "components/sync_driver/pref_names.h" |
+#include "components/sync_driver/sync_prefs.h" |
#include "content/public/browser/notification_service.h" |
#include "content/public/browser/notification_source.h" |
#include "content/public/test/test_browser_thread_bundle.h" |
@@ -171,7 +172,7 @@ class ProfileSyncServiceStartupCrosTest : public ProfileSyncServiceStartupTest { |
TEST_F(ProfileSyncServiceStartupTest, StartFirstTime) { |
// We've never completed startup. |
- profile_->GetPrefs()->ClearPref(prefs::kSyncHasSetupCompleted); |
+ profile_->GetPrefs()->ClearPref(sync_driver::prefs::kSyncHasSetupCompleted); |
CreateSyncService(); |
SetUpSyncBackendHost(); |
DataTypeManagerMock* data_type_manager = SetUpDataTypeManager(); |
@@ -183,8 +184,11 @@ TEST_F(ProfileSyncServiceStartupTest, StartFirstTime) { |
sync_->Initialize(); |
// Preferences should be back to defaults. |
- EXPECT_EQ(0, profile_->GetPrefs()->GetInt64(prefs::kSyncLastSyncedTime)); |
- EXPECT_FALSE(profile_->GetPrefs()->GetBoolean(prefs::kSyncHasSetupCompleted)); |
+ EXPECT_EQ( |
+ 0, |
+ profile_->GetPrefs()->GetInt64(sync_driver::prefs::kSyncLastSyncedTime)); |
+ EXPECT_FALSE(profile_->GetPrefs()->GetBoolean( |
+ sync_driver::prefs::kSyncHasSetupCompleted)); |
Mock::VerifyAndClearExpectations(data_type_manager); |
// Then start things up. |
@@ -218,7 +222,7 @@ TEST_F(ProfileSyncServiceStartupTest, StartFirstTime) { |
// TODO(pavely): Reenable test once android is switched to oauth2. |
TEST_F(ProfileSyncServiceStartupTest, DISABLED_StartNoCredentials) { |
// We've never completed startup. |
- profile_->GetPrefs()->ClearPref(prefs::kSyncHasSetupCompleted); |
+ profile_->GetPrefs()->ClearPref(sync_driver::prefs::kSyncHasSetupCompleted); |
CreateSyncService(); |
// Should not actually start, rather just clean things up and wait |
@@ -229,8 +233,11 @@ TEST_F(ProfileSyncServiceStartupTest, DISABLED_StartNoCredentials) { |
sync_->Initialize(); |
// Preferences should be back to defaults. |
- EXPECT_EQ(0, profile_->GetPrefs()->GetInt64(prefs::kSyncLastSyncedTime)); |
- EXPECT_FALSE(profile_->GetPrefs()->GetBoolean(prefs::kSyncHasSetupCompleted)); |
+ EXPECT_EQ( |
+ 0, |
+ profile_->GetPrefs()->GetInt64(sync_driver::prefs::kSyncLastSyncedTime)); |
+ EXPECT_FALSE(profile_->GetPrefs()->GetBoolean( |
+ sync_driver::prefs::kSyncHasSetupCompleted)); |
// Then start things up. |
sync_->SetSetupInProgress(true); |
@@ -303,7 +310,7 @@ TEST_F(ProfileSyncServiceStartupCrosTest, StartCrosNoCredentials) { |
CreateDataTypeManager(_, _, _, _, _, _)).Times(0); |
EXPECT_CALL(*components_factory_mock(), |
CreateSyncBackendHost(_, _, _)).Times(0); |
- profile_->GetPrefs()->ClearPref(prefs::kSyncHasSetupCompleted); |
+ profile_->GetPrefs()->ClearPref(sync_driver::prefs::kSyncHasSetupCompleted); |
EXPECT_CALL(observer_, OnStateChanged()).Times(AnyNumber()); |
sync_->Initialize(); |
@@ -318,7 +325,7 @@ TEST_F(ProfileSyncServiceStartupCrosTest, StartCrosNoCredentials) { |
TEST_F(ProfileSyncServiceStartupCrosTest, StartFirstTime) { |
SetUpSyncBackendHost(); |
DataTypeManagerMock* data_type_manager = SetUpDataTypeManager(); |
- profile_->GetPrefs()->ClearPref(prefs::kSyncHasSetupCompleted); |
+ profile_->GetPrefs()->ClearPref(sync_driver::prefs::kSyncHasSetupCompleted); |
EXPECT_CALL(*data_type_manager, Configure(_, _)); |
EXPECT_CALL(*data_type_manager, state()). |
WillRepeatedly(Return(DataTypeManager::CONFIGURED)); |
@@ -356,12 +363,13 @@ TEST_F(ProfileSyncServiceStartupTest, StartNormal) { |
// therefore being left unset. |
TEST_F(ProfileSyncServiceStartupTest, StartRecoverDatatypePrefs) { |
// Clear the datatype preference fields (simulating bug 154940). |
- profile_->GetPrefs()->ClearPref(prefs::kSyncKeepEverythingSynced); |
+ profile_->GetPrefs()->ClearPref( |
+ sync_driver::prefs::kSyncKeepEverythingSynced); |
syncer::ModelTypeSet user_types = syncer::UserTypes(); |
for (syncer::ModelTypeSet::Iterator iter = user_types.First(); |
iter.Good(); iter.Inc()) { |
profile_->GetPrefs()->ClearPref( |
- browser_sync::SyncPrefs::GetPrefNameForDataType(iter.Get())); |
+ sync_driver::SyncPrefs::GetPrefNameForDataType(iter.Get())); |
} |
// Pre load the tokens |
@@ -383,7 +391,7 @@ TEST_F(ProfileSyncServiceStartupTest, StartRecoverDatatypePrefs) { |
sync_->Initialize(); |
EXPECT_TRUE(profile_->GetPrefs()->GetBoolean( |
- prefs::kSyncKeepEverythingSynced)); |
+ sync_driver::prefs::kSyncKeepEverythingSynced)); |
} |
// Verify that the recovery of datatype preferences doesn't overwrite a valid |
@@ -391,7 +399,8 @@ TEST_F(ProfileSyncServiceStartupTest, StartRecoverDatatypePrefs) { |
TEST_F(ProfileSyncServiceStartupTest, StartDontRecoverDatatypePrefs) { |
// Explicitly set Keep Everything Synced to false and have only bookmarks |
// enabled. |
- profile_->GetPrefs()->SetBoolean(prefs::kSyncKeepEverythingSynced, false); |
+ profile_->GetPrefs()->SetBoolean( |
+ sync_driver::prefs::kSyncKeepEverythingSynced, false); |
// Pre load the tokens |
profile_->GetPrefs()->SetString(prefs::kGoogleServicesUsername, |
@@ -411,7 +420,7 @@ TEST_F(ProfileSyncServiceStartupTest, StartDontRecoverDatatypePrefs) { |
sync_->Initialize(); |
EXPECT_FALSE(profile_->GetPrefs()->GetBoolean( |
- prefs::kSyncKeepEverythingSynced)); |
+ sync_driver::prefs::kSyncKeepEverythingSynced)); |
} |
TEST_F(ProfileSyncServiceStartupTest, ManagedStartup) { |
@@ -421,7 +430,7 @@ TEST_F(ProfileSyncServiceStartupTest, ManagedStartup) { |
CreateSyncService(); |
// Disable sync through policy. |
- profile_->GetPrefs()->SetBoolean(prefs::kSyncManaged, true); |
+ profile_->GetPrefs()->SetBoolean(sync_driver::prefs::kSyncManaged, true); |
EXPECT_CALL(*components_factory_mock(), |
CreateDataTypeManager(_, _, _, _, _, _)).Times(0); |
EXPECT_CALL(observer_, OnStateChanged()).Times(AnyNumber()); |
@@ -449,7 +458,7 @@ TEST_F(ProfileSyncServiceStartupTest, SwitchManaged) { |
WillOnce(Return(DataTypeManager::CONFIGURED)); |
EXPECT_CALL(*data_type_manager, Stop()).Times(1); |
EXPECT_CALL(observer_, OnStateChanged()).Times(AnyNumber()); |
- profile_->GetPrefs()->SetBoolean(prefs::kSyncManaged, true); |
+ profile_->GetPrefs()->SetBoolean(sync_driver::prefs::kSyncManaged, true); |
// When switching back to unmanaged, the state should change, but the service |
// should not start up automatically (kSyncSetupCompleted will be false). |
@@ -457,7 +466,7 @@ TEST_F(ProfileSyncServiceStartupTest, SwitchManaged) { |
EXPECT_CALL(*components_factory_mock(), |
CreateDataTypeManager(_, _, _, _, _, _)).Times(0); |
EXPECT_CALL(observer_, OnStateChanged()).Times(AnyNumber()); |
- profile_->GetPrefs()->ClearPref(prefs::kSyncManaged); |
+ profile_->GetPrefs()->ClearPref(sync_driver::prefs::kSyncManaged); |
} |
TEST_F(ProfileSyncServiceStartupTest, StartFailure) { |
@@ -505,7 +514,7 @@ TEST_F(ProfileSyncServiceStartupTest, StartDownloadFailed) { |
SyncBackendHostMock* mock_sbh = SetUpSyncBackendHost(); |
mock_sbh->set_fail_initial_download(true); |
- profile_->GetPrefs()->ClearPref(prefs::kSyncHasSetupCompleted); |
+ profile_->GetPrefs()->ClearPref(sync_driver::prefs::kSyncHasSetupCompleted); |
EXPECT_CALL(observer_, OnStateChanged()).Times(AnyNumber()); |
sync_->Initialize(); |