Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: chrome/browser/sync/profile_sync_service.cc

Issue 195873020: [Sync] Move SyncPrefs into sync_driver component (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rerererebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/profile_sync_service.h ('k') | chrome/browser/sync/profile_sync_service_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_service.cc
diff --git a/chrome/browser/sync/profile_sync_service.cc b/chrome/browser/sync/profile_sync_service.cc
index 5bae7d1b4533d66b175286836b6e3d3916d9a1f9..616c2bb45bcddde7cf59e6ba39c8c3ba4ad1004d 100644
--- a/chrome/browser/sync/profile_sync_service.cc
+++ b/chrome/browser/sync/profile_sync_service.cc
@@ -64,6 +64,7 @@
#include "chrome/common/url_constants.h"
#include "components/signin/core/profile_oauth2_token_service.h"
#include "components/sync_driver/data_type_controller.h"
+#include "components/sync_driver/pref_names.h"
#include "components/sync_driver/system_encryptor.h"
#include "components/sync_driver/user_selectable_sync_type.h"
#include "components/user_prefs/pref_registry_syncable.h"
@@ -310,7 +311,8 @@ void ProfileSyncService::TrySyncDatatypePrefRecovery() {
return;
const PrefService::Preference* keep_everything_synced =
- pref_service->FindPreference(prefs::kSyncKeepEverythingSynced);
+ pref_service->FindPreference(
+ sync_driver::prefs::kSyncKeepEverythingSynced);
// This will be false if the preference was properly set or if it's controlled
// by policy.
if (!keep_everything_synced->IsDefaultValue())
@@ -1010,35 +1012,38 @@ void ProfileSyncService::OnExperimentsChanged(
}
int bookmarks_experiment_state_before = profile_->GetPrefs()->GetInteger(
- prefs::kEnhancedBookmarksExperimentEnabled);
+ sync_driver::prefs::kEnhancedBookmarksExperimentEnabled);
// kEnhancedBookmarksExperiment flag could have values "", "1" and "0".
// "" and "1" means experiment is enabled.
if ((CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
switches::kEnhancedBookmarksExperiment) != "0")) {
- profile_->GetPrefs()->SetInteger(prefs::kEnhancedBookmarksExperimentEnabled,
- experiments.enhanced_bookmarks_enabled ?
- kBookmarksExperimentEnabled :
- kNoBookmarksExperiment);
- profile_->GetPrefs()->SetString(prefs::kEnhancedBookmarksExtensionId,
- experiments.enhanced_bookmarks_ext_id);
+ profile_->GetPrefs()->SetInteger(
+ sync_driver::prefs::kEnhancedBookmarksExperimentEnabled,
+ experiments.enhanced_bookmarks_enabled ? kBookmarksExperimentEnabled
+ : kNoBookmarksExperiment);
+ profile_->GetPrefs()->SetString(
+ sync_driver::prefs::kEnhancedBookmarksExtensionId,
+ experiments.enhanced_bookmarks_ext_id);
} else {
// User opt-out from chrome://flags
if (experiments.enhanced_bookmarks_enabled) {
profile_->GetPrefs()->SetInteger(
- prefs::kEnhancedBookmarksExperimentEnabled,
+ sync_driver::prefs::kEnhancedBookmarksExperimentEnabled,
kBookmarksExperimentEnabledUserOptOut);
// Keep extension id up-to-date in case will opt-in later.
- profile_->GetPrefs()->SetString(prefs::kEnhancedBookmarksExtensionId,
- experiments.enhanced_bookmarks_ext_id);
+ profile_->GetPrefs()->SetString(
+ sync_driver::prefs::kEnhancedBookmarksExtensionId,
+ experiments.enhanced_bookmarks_ext_id);
} else {
profile_->GetPrefs()->ClearPref(
- prefs::kEnhancedBookmarksExperimentEnabled);
- profile_->GetPrefs()->ClearPref(prefs::kEnhancedBookmarksExtensionId);
+ sync_driver::prefs::kEnhancedBookmarksExperimentEnabled);
+ profile_->GetPrefs()->ClearPref(
+ sync_driver::prefs::kEnhancedBookmarksExtensionId);
}
}
BookmarksExperimentState bookmarks_experiment_state =
static_cast<BookmarksExperimentState>(profile_->GetPrefs()->GetInteger(
- prefs::kEnhancedBookmarksExperimentEnabled));
+ sync_driver::prefs::kEnhancedBookmarksExperimentEnabled));
// If bookmark experiment state was changed update about flags experiment.
if (bookmarks_experiment_state_before != bookmarks_experiment_state) {
UpdateBookmarksExperiment(g_browser_process->local_state(),
@@ -2126,7 +2131,7 @@ void ProfileSyncService::UnsuppressAndStart() {
if (signin_.get() &&
signin_->GetOriginal()->GetAuthenticatedUsername().empty()) {
signin_->GetOriginal()->SetAuthenticatedUsername(
- sync_prefs_.GetGoogleServicesUsername());
+ profile_->GetPrefs()->GetString(prefs::kGoogleServicesUsername));
}
startup_controller_.TryStart();
}
« no previous file with comments | « chrome/browser/sync/profile_sync_service.h ('k') | chrome/browser/sync/profile_sync_service_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698