Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: content/browser/renderer_host/gamepad_browser_message_filter.cc

Issue 195873019: Gamepad API: add support for connection events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add some more comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/gamepad_browser_message_filter.cc
diff --git a/content/browser/renderer_host/gamepad_browser_message_filter.cc b/content/browser/renderer_host/gamepad_browser_message_filter.cc
index cd36e6ac5e8f6632bd57b8e106a5036e92894b52..d6f193f838287f4400dbfcda986a58a429929630 100644
--- a/content/browser/renderer_host/gamepad_browser_message_filter.cc
+++ b/content/browser/renderer_host/gamepad_browser_message_filter.cc
@@ -9,15 +9,16 @@
namespace content {
-GamepadBrowserMessageFilter::GamepadBrowserMessageFilter()
+GamepadBrowserMessageFilter::GamepadBrowserMessageFilter(IPC::Sender* sender)
: BrowserMessageFilter(GamepadMsgStart),
+ sender_(sender),
is_started_(false) {
}
GamepadBrowserMessageFilter::~GamepadBrowserMessageFilter() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
if (is_started_)
- GamepadService::GetInstance()->RemoveConsumer();
+ GamepadService::GetInstance()->RemoveConsumer(this);
}
bool GamepadBrowserMessageFilter::OnMessageReceived(
@@ -34,28 +35,33 @@ bool GamepadBrowserMessageFilter::OnMessageReceived(
return handled;
}
+void GamepadBrowserMessageFilter::OnGamepadConnected(
+ unsigned index,
+ const blink::WebGamepad& web_gamepad) {
+ sender_->Send(new GamepadMsg_GamepadConnected(
+ GamepadConnectionEventMessageParams(index, web_gamepad)));
+}
+
+void GamepadBrowserMessageFilter::OnGamepadDisconnected(
+ unsigned index,
+ const blink::WebGamepad& web_gamepad) {
+ sender_->Send(new GamepadMsg_GamepadDisconnected(
+ GamepadConnectionEventMessageParams(index, web_gamepad)));
+}
+
void GamepadBrowserMessageFilter::OnGamepadStartPolling(
base::SharedMemoryHandle* renderer_handle) {
GamepadService* service = GamepadService::GetInstance();
- if (!is_started_) {
- is_started_ = true;
- service->AddConsumer();
- *renderer_handle = service->GetSharedMemoryHandleForProcess(PeerHandle());
- } else {
- // Currently we only expect the renderer to tell us once to start.
- NOTREACHED();
- }
+ CHECK(!is_started_);
+ is_started_ = true;
+ service->AddConsumer(this);
+ *renderer_handle = service->GetSharedMemoryHandleForProcess(PeerHandle());
}
void GamepadBrowserMessageFilter::OnGamepadStopPolling() {
- // TODO(scottmg): Probably get rid of this message. We can't trust it will
- // arrive anyway if the renderer crashes, etc.
- if (is_started_) {
- is_started_ = false;
- GamepadService::GetInstance()->RemoveConsumer();
- } else {
- NOTREACHED();
- }
+ CHECK(is_started_);
+ is_started_ = false;
+ GamepadService::GetInstance()->RemoveConsumer(this);
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698