Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1958713003: Various species micro-optimizations (Closed)

Created:
4 years, 7 months ago by Dan Ehrenberg
Modified:
4 years, 7 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Various species micro-optimizations - Inline reads to the species protector - Put V8_LIKELY/V8_UNLIKELY to guide Array.prototype.{slice,splice,concat} to the fast paths - Put the Array species good path checks directly in Array.prototype.concat to avoid a couple reads of the array constructor from the native context These changes together bring a ~4-6% win on kraken-orig/stanford-crypto-pbkdf2-orig which more than makes up from the performance degradation from a recent other species-related change. BUG=chromium:609739 R=cbruni@chromium.org LOG=Y Committed: https://crrev.com/f98caf44b80d826227ae5daaac465aa0969a74dc Cr-Commit-Position: refs/heads/master@{#36121}

Patch Set 1 #

Patch Set 2 : Fix bug and formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -31 lines) Patch
M src/builtins.cc View 1 3 chunks +21 lines, -11 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/isolate-inl.h View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Dan Ehrenberg
4 years, 7 months ago (2016-05-06 23:17:49 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958713003/1
4 years, 7 months ago (2016-05-09 21:23:30 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/1350) v8_linux64_avx2_rel_ng_triggered on ...
4 years, 7 months ago (2016-05-09 21:42:00 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958713003/20001
4 years, 7 months ago (2016-05-09 22:22:11 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-09 22:52:41 UTC) #11
Camillo Bruni
LGTM, sorry for the delay.
4 years, 7 months ago (2016-05-10 06:47:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958713003/20001
4 years, 7 months ago (2016-05-10 06:52:21 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 06:54:24 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 06:54:45 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f98caf44b80d826227ae5daaac465aa0969a74dc
Cr-Commit-Position: refs/heads/master@{#36121}

Powered by Google App Engine
This is Rietveld 408576698