Issue 19587003: Test decoding the bounds in skimage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19587003: Test decoding the bounds in skimage. (Closed)

Created:
7 years, 5 months ago by scroggo

Modified:
7 years, 5 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Test decoding the bounds in skimage. Test that the bounds match the bounds from doing a pixel decode. R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=10164

Patch Set 2 : Remove extra newline #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	tools/skimage_main.cpp	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

djsollen

lgtm https://codereview.chromium.org/19587003/diff/1/tools/skimage_main.cpp File tools/skimage_main.cpp (right): https://codereview.chromium.org/19587003/diff/1/tools/skimage_main.cpp#newcode315 tools/skimage_main.cpp:315: extra space?

7 years, 5 months ago (2013-07-17 18:34:16 UTC) #2

scroggo

https://codereview.chromium.org/19587003/diff/1/tools/skimage_main.cpp File tools/skimage_main.cpp (right): https://codereview.chromium.org/19587003/diff/1/tools/skimage_main.cpp#newcode315 tools/skimage_main.cpp:315: On 2013/07/17 18:34:16, djsollen wrote: > extra space? D'oh! ...

7 years, 5 months ago (2013-07-17 19:14:30 UTC) #3

scroggo

7 years, 5 months ago (2013-07-18 20:08:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r10164 (presubmit successful).

Expand Messages | Collapse Messages

Issue 19587003: Test decoding the bounds in skimage. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove extra newline #

Messages