Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1958683002: Fix void subtype checks. (Closed)

Created:
4 years, 7 months ago by Leaf
Modified:
4 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -27 lines) Patch
M lib/runtime/dart_sdk.js View 1 chunk +3 lines, -7 lines 0 comments Download
M test/browser/runtime_tests.js View 2 chunks +52 lines, -5 lines 0 comments Download
M tool/input_sdk/private/ddc_runtime/types.dart View 1 chunk +6 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
4 years, 7 months ago (2016-05-06 17:17:20 UTC) #2
vsm
lgtm
4 years, 7 months ago (2016-05-06 19:56:59 UTC) #3
Leaf
4 years, 7 months ago (2016-05-06 21:04:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab5cdde777e780fedc59fa8083b4696bfb3f5d95 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698