Use DiscardableMemoryManager on Android.

base/memory/discardable_memory_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/discardable_memory_manager.h"
 
 #include "base/bind.h"
 #include "base/run_loop.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/threading/thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
 namespace {
 
 class TestAllocationImpl : public internal::DiscardableMemoryManagerAllocation {
  public:
-  TestAllocationImpl() : is_allocated_(false), is_locked_(false) {}
+  TestAllocationImpl() : is_allocated_(false), is_locked_(false), bytes_(0) {}
   virtual ~TestAllocationImpl() { DCHECK(!is_locked_); }
 
   // Overridden from internal::DiscardableMemoryManagerAllocation:
   virtual bool AllocateAndAcquireLock(size_t bytes) OVERRIDE {
     bool was_allocated = is_allocated_;
     is_allocated_ = true;
     DCHECK(!is_locked_);
     is_locked_ = true;
+    DCHECK(!bytes_ || bytes_ == bytes);

[reveman, 2014/04/26 00:13:37]

how about we remove the |bytes| parameter from AllocateAndAcquireLock instead?

[Philippe, 2014/04/28 12:23:14]

Good idea, I was tempted to make the change too.

+    bytes_ = bytes;
     return was_allocated;
   }
   virtual void ReleaseLock() OVERRIDE {
-    DCHECK(is_locked_);
+    DCHECK_EQ(is_locked_, is_allocated_);

[reveman, 2014/04/26 00:13:37]

hm, this seems unnecessary. What sequence of events does this cover that was not
covered before?

[Philippe, 2014/04/28 12:23:14]

I think this was needed for the zero allocation (with my changes in Unregister()
though). I have now reverted my changes in the manager though.

     is_locked_ = false;
   }
   virtual void Purge() OVERRIDE {
-    DCHECK(is_allocated_);
+    // Allocation only happens for non-zero sizes.
+    DCHECK_EQ(is_allocated_, !!bytes_);
     is_allocated_ = false;
+    bytes_ = 0;
   }
 
   bool is_locked() const { return is_locked_; }
 
  private:
   bool is_allocated_;
   bool is_locked_;
+  size_t bytes_;
 };
 
 class DiscardableMemoryManagerTestBase {
  public:
   DiscardableMemoryManagerTestBase() {
     manager_.RegisterMemoryPressureListener();
   }
 
  protected:
   enum LockStatus {
@@ skipping 364 matching lines @@
            Unretained(this)));
   memory_usage_thread_.message_loop()->PostTask(
       FROM_HERE,
       Bind(&ThreadedDiscardableMemoryManagerTest::SignalHelper,
            Unretained(this)));
   thread_sync_.Wait();
 }
 
 }  // namespace
 }  // namespace base